Lots of progress switching to SkColorSpace rather than SkColorProfileType

Lots of progress on switching to SkColorSpace rather than SkColorProfileType

Fixed a bunch of code in Ganesh, as well as usage of SkColorProfileType in most of our tools (DM, SampleApp, Viewer, nanobench, skiaserve, HelloWorld).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2069173002

Committed: https://skia.googlesource.com/skia/+/6a61a875467646f8dbc37cfecf49e12d1f475170
Committed: https://skia.googlesource.com/skia/+/b109b8c5ec40a7dd85a0a2951a1f98fa63b805aa

[Brian Osman, 2016-06-15 17:14:30]

Description was changed from

==========
Switching to use SkColorSpace rather than SkColorProfileType

BUG=skia:
==========

to

==========
Switching to use SkColorSpace rather than SkColorProfileType

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2069173002
==========

[Brian Osman, 2016-06-15 17:33:11]

Description was changed from

==========
Switching to use SkColorSpace rather than SkColorProfileType

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2069173002
==========

to

==========
Switching to use SkColorSpace rather than SkColorProfileType

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2069173002
==========

[Brian Osman, 2016-06-16 14:05:25]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-16 14:05:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2069173002/120001

[commit-bot: I haz the power, 2016-06-16 14:19:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-16 14:19:21]

Dry run: This issue passed the CQ dry run.

[Brian Osman, 2016-06-16 14:56:03]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-16 14:56:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2069173002/160001

[Brian Osman, 2016-06-16 15:14:10]

Description was changed from

==========
Switching to use SkColorSpace rather than SkColorProfileType

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2069173002
==========

to

==========
Lots of progress on switching to SkColorSpace rather than SkColorProfileType

Fixed a bunch of code in Ganesh, as well as usage of SkColorProfileType in most
of our tools (DM, SampleApp, Viewer, nanobench, skiaserve, HelloWorld).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2069173002
==========

[Brian Osman, 2016-06-16 15:15:05]

brianosman@google.com changed reviewers:
+ herb@google.com, msarett@google.com, reed@google.com

[Brian Osman, 2016-06-16 15:15:06]

https://codereview.chromium.org/2069173002/diff/160001/samplecode/SampleApp.cpp
File samplecode/SampleApp.cpp (right):

https://codereview.chromium.org/2069173002/diff/160001/samplecode/SampleApp.c...
samplecode/SampleApp.cpp:51: bool                fSRGB;
Not using sk_sp<SkColorSpace> here to avoid static initialization race
conditions when filling out the gConfig array.

[commit-bot: I haz the power, 2016-06-16 15:46:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-16 15:46:16]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-06-16 15:56:04]

Woo this is awesome!  Thanks Brian for taking this on!
LGTM

https://codereview.chromium.org/2069173002/diff/160001/example/HelloWorld.cpp
File example/HelloWorld.cpp (right):

https://codereview.chromium.org/2069173002/diff/160001/example/HelloWorld.cpp...
example/HelloWorld.cpp:158: SkImageInfo2GrPixelConfig(info, *fContext->caps()),
nit: formatting

Feel free to ignore this comment.

https://codereview.chromium.org/2069173002/diff/160001/samplecode/SampleApp.cpp
File samplecode/SampleApp.cpp (right):

https://codereview.chromium.org/2069173002/diff/160001/samplecode/SampleApp.c...
samplecode/SampleApp.cpp:51: bool                fSRGB;
On 2016/06/16 15:15:06, Brian Osman wrote:
> Not using sk_sp<SkColorSpace> here to avoid static initialization race
> conditions when filling out the gConfig array.

Acknowledged.

[Brian Osman, 2016-06-16 16:41:34]

The CQ bit was checked by brianosman@google.com

[Brian Osman, 2016-06-16 16:41:35]

The patchset sent to the CQ was uploaded after l-g-t-m from msarett@google.com
Link to the patchset: https://codereview.chromium.org/2069173002/#ps180001
(title: "Formatting fix")

[commit-bot: I haz the power, 2016-06-16 16:41:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2069173002/180001

[commit-bot: I haz the power, 2016-06-16 16:43:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-16 16:43:50]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[reed1, 2016-06-16 18:08:15]

lgtm

[Brian Osman, 2016-06-16 18:08:34]

The CQ bit was checked by brianosman@google.com

[commit-bot: I haz the power, 2016-06-16 18:08:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2069173002/180001

[commit-bot: I haz the power, 2016-06-16 18:10:06]

Description was changed from

==========
Lots of progress on switching to SkColorSpace rather than SkColorProfileType

Fixed a bunch of code in Ganesh, as well as usage of SkColorProfileType in most
of our tools (DM, SampleApp, Viewer, nanobench, skiaserve, HelloWorld).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2069173002
==========

to

==========
Lots of progress on switching to SkColorSpace rather than SkColorProfileType

Fixed a bunch of code in Ganesh, as well as usage of SkColorProfileType in most
of our tools (DM, SampleApp, Viewer, nanobench, skiaserve, HelloWorld).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2069173002

Committed:
https://skia.googlesource.com/skia/+/6a61a875467646f8dbc37cfecf49e12d1f475170
==========

[commit-bot: I haz the power, 2016-06-16 18:10:07]

Committed patchset #10 (id:180001) as
https://skia.googlesource.com/skia/+/6a61a875467646f8dbc37cfecf49e12d1f475170

[Brian Osman, 2016-06-16 18:41:17]

A revert of this CL (patchset #10 id:180001) has been created in
https://codereview.chromium.org/2072813002/ by brianosman@google.com.

The reason for reverting is: Mac crashes in GrUploadPixmapToTexture.

[Brian Osman, 2016-06-16 19:37:16]

Description was changed from

==========
Lots of progress on switching to SkColorSpace rather than SkColorProfileType

Fixed a bunch of code in Ganesh, as well as usage of SkColorProfileType in most
of our tools (DM, SampleApp, Viewer, nanobench, skiaserve, HelloWorld).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2069173002

Committed:
https://skia.googlesource.com/skia/+/6a61a875467646f8dbc37cfecf49e12d1f475170
==========

to

==========
Lots of progress on switching to SkColorSpace rather than SkColorProfileType

Fixed a bunch of code in Ganesh, as well as usage of SkColorProfileType in most
of our tools (DM, SampleApp, Viewer, nanobench, skiaserve, HelloWorld).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2069173002

Committed:
https://skia.googlesource.com/skia/+/6a61a875467646f8dbc37cfecf49e12d1f475170
==========

[Brian Osman, 2016-06-16 19:42:34]

The CQ bit was checked by brianosman@google.com

[Brian Osman, 2016-06-16 19:42:34]

The patchset sent to the CQ was uploaded after l-g-t-m from msarett@google.com,
reed@google.com
Link to the patchset: https://codereview.chromium.org/2069173002/#ps200001
(title: "Fix bad assert")

[commit-bot: I haz the power, 2016-06-16 19:42:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2069173002/200001

[commit-bot: I haz the power, 2016-06-16 20:03:27]

Description was changed from

==========
Lots of progress on switching to SkColorSpace rather than SkColorProfileType

Fixed a bunch of code in Ganesh, as well as usage of SkColorProfileType in most
of our tools (DM, SampleApp, Viewer, nanobench, skiaserve, HelloWorld).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2069173002

Committed:
https://skia.googlesource.com/skia/+/6a61a875467646f8dbc37cfecf49e12d1f475170
==========

to

==========
Lots of progress on switching to SkColorSpace rather than SkColorProfileType

Fixed a bunch of code in Ganesh, as well as usage of SkColorProfileType in most
of our tools (DM, SampleApp, Viewer, nanobench, skiaserve, HelloWorld).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2069173002

Committed:
https://skia.googlesource.com/skia/+/6a61a875467646f8dbc37cfecf49e12d1f475170
Committed:
https://skia.googlesource.com/skia/+/b109b8c5ec40a7dd85a0a2951a1f98fa63b805aa
==========

[commit-bot: I haz the power, 2016-06-16 20:03:29]

Committed patchset #11 (id:200001) as
https://skia.googlesource.com/skia/+/b109b8c5ec40a7dd85a0a2951a1f98fa63b805aa