tools/viewer/sk_app/DisplayParams.h - Issue 2069173002: Lots of progress switching to SkColorSpace rather than SkColorProfileType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/viewer/sk_app/DisplayParams.h

Issue 2069173002: Lots of progress switching to SkColorSpace rather than SkColorProfileType (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Fix bad assert Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/viewer/sk_app/DisplayParams.h

diff --git a/tools/viewer/sk_app/DisplayParams.h b/tools/viewer/sk_app/DisplayParams.h

index 8756ff0aac16f4b82445447374e10868c6784ca2..b9a23f322d038b8981ad638ef931d11ca309b0d9 100644

--- a/tools/viewer/sk_app/DisplayParams.h

+++ b/tools/viewer/sk_app/DisplayParams.h

@@ -14,14 +14,14 @@ namespace sk_app {

struct DisplayParams {

DisplayParams()

: fColorType(kN32_SkColorType)

- , fProfileType(kLinear_SkColorProfileType)

+ , fColorSpace(nullptr)

, fMSAASampleCount(0)

, fDeepColor(false) {}

- SkColorType fColorType;

- SkColorProfileType fProfileType;

- int fMSAASampleCount;

- bool fDeepColor;

+ SkColorType fColorType;

+ sk_sp<SkColorSpace> fColorSpace;

+ int fMSAASampleCount;

+ bool fDeepColor;

};

} // namespace sk_app

« no previous file with comments | « tools/viewer/Viewer.cpp ('k') | tools/viewer/sk_app/GLWindowContext.cpp » ('j') | no next file with comments »