tests/ReadPixelsTest.cpp - Issue 2069173002: Lots of progress switching to SkColorSpace rather than SkColorProfileType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/ReadPixelsTest.cpp

Issue 2069173002: Lots of progress switching to SkColorSpace rather than SkColorProfileType (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Fix bad assert Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/ReadPixelsTest.cpp

diff --git a/tests/ReadPixelsTest.cpp b/tests/ReadPixelsTest.cpp

index a4c36ffa5d79f263099fb0cdc91e0c04852b6736..a4dbae9eb75e2a2fe8e0914122349ccebd12d71b 100644

--- a/tests/ReadPixelsTest.cpp

+++ b/tests/ReadPixelsTest.cpp

@@ -424,7 +424,7 @@ static void test_readpixels_texture(skiatest::Reporter* reporter, GrTexture* tex

GrPixelConfig dstConfig =

SkImageInfo2GrPixelConfig(gReadPixelsConfigs[c].fColorType,

gReadPixelsConfigs[c].fAlphaType,

- kLinear_SkColorProfileType,

+ nullptr,

*texture->getContext()->caps());

uint32_t flags = 0;

if (gReadPixelsConfigs[c].fAlphaType == kUnpremul_SkAlphaType) {

« no previous file with comments | « src/views/SkWindow.cpp ('k') | tests/TestConfigParsing.cpp » ('j') | no next file with comments »