Fix memory leaks with V8 startup data.

Fix memory leaks with V8 startup data.

Committed: https://pdfium.googlesource.com/pdfium/+/c08cd7abb2069b6056ec99c8ec5b87524e45df01

[Lei Zhang, 2016-06-13 23:19:10]

thestig@chromium.org changed reviewers:
+ jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-06-20 11:41:44]

lgtm

[Lei Zhang, 2016-06-20 12:44:18]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-06-20 12:44:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2068563002/1

[commit-bot: I haz the power, 2016-06-20 13:04:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-20 13:04:28]

Try jobs failed on following builders:
  linux_xfa_rel_gn on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa_rel_g...)

[Lei Zhang, 2016-06-20 18:57:07]

With patch set 3, we only leak once. Maybe we can fix the one time leak if I can
figure out when gtest is done?

https://codereview.chromium.org/2068563002/diff/1/testing/embedder_test.cpp
File testing/embedder_test.cpp (right):

https://codereview.chromium.org/2068563002/diff/1/testing/embedder_test.cpp#n...
testing/embedder_test.cpp:67: free(const_cast<char*>(natives_.data));
Not sure why I didn't notice the bot failure earlier / notice the failure
locally, but this doesn't work since v8::V8::SetNativesDataBlob() uses
base::CallOnce() internally. I think we'll have to tolerate at least 1 leak.

[Lei Zhang, 2016-06-20 22:49:21]

PTAL at patch set 5.

[jochen (gone - plz use gerrit), 2016-06-27 08:02:49]

lgtm

[Lei Zhang, 2016-06-27 16:35:14]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-06-27 16:35:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 16:48:02]

Description was changed from

==========
Fix memory leaks with V8 startup data.
==========

to

==========
Fix memory leaks with V8 startup data.

Committed:
https://pdfium.googlesource.com/pdfium/+/c08cd7abb2069b6056ec99c8ec5b87524e45...
==========

[commit-bot: I haz the power, 2016-06-27 16:48:03]

Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/c08cd7abb2069b6056ec99c8ec5b87524e45...