Fix memory leaks with V8 startup data.

testing/embedder_test.cpp

 // Copyright 2015 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "testing/embedder_test.h"
 
 #include <limits.h>
 
 #include <list>
 #include <string>
 #include <utility>
 #include <vector>
 
 #include "public/fpdf_dataavail.h"
 #include "public/fpdf_edit.h"
 #include "public/fpdf_text.h"
 #include "public/fpdfview.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/test_support.h"
 #include "testing/utils/path_service.h"
 
 #ifdef PDF_ENABLE_V8
 #include "v8/include/v8-platform.h"
 #include "v8/include/v8.h"
 #endif  // PDF_ENABLE_V8
 
 namespace {
-const char* g_exe_path_ = nullptr;
+
+const char* g_exe_path = nullptr;
+
+#ifdef PDF_ENABLE_V8
+#ifdef V8_USE_EXTERNAL_STARTUP_DATA
+v8::StartupData* g_v8_natives = nullptr;
+v8::StartupData* g_v8_snapshot = nullptr;
+#endif  // V8_USE_EXTERNAL_STARTUP_DATA
+#endif  // PDF_ENABLE_V8
+
 }  // namespace
 
 FPDF_BOOL Is_Data_Avail(FX_FILEAVAIL* pThis, size_t offset, size_t size) {
   return true;
 }
 
 void Add_Segment(FX_DOWNLOADHINTS* pThis, size_t offset, size_t size) {}
 
 EmbedderTest::EmbedderTest()
     : default_delegate_(new EmbedderTest::Delegate()),
       document_(nullptr),
       form_handle_(nullptr),
       avail_(nullptr),
       external_isolate_(nullptr),
       loader_(nullptr),
       file_length_(0),
       file_contents_(nullptr) {
   memset(&hints_, 0, sizeof(hints_));
   memset(&file_access_, 0, sizeof(file_access_));
   memset(&file_avail_, 0, sizeof(file_avail_));
   delegate_ = default_delegate_.get();
 
 #ifdef PDF_ENABLE_V8
 #ifdef V8_USE_EXTERNAL_STARTUP_DATA
-  InitializeV8ForPDFium(g_exe_path_, std::string(), &natives_, &snapshot_,
-                        &platform_);
+  if (g_v8_natives && g_v8_snapshot) {
+    InitializeV8ForPDFium(g_exe_path, std::string(), nullptr, nullptr,
+                          &platform_);
+  } else {
+    g_v8_natives = new v8::StartupData;
+    g_v8_snapshot = new v8::StartupData;
+    InitializeV8ForPDFium(g_exe_path, std::string(), g_v8_natives,
+                          g_v8_snapshot, &platform_);
+  }
 #else
-  InitializeV8ForPDFium(g_exe_path_, &platform_);
+  InitializeV8ForPDFium(g_exe_path, &platform_);
 #endif  // V8_USE_EXTERNAL_STARTUP_DATA
 #endif  // FPDF_ENABLE_V8
 }
 
 EmbedderTest::~EmbedderTest() {
 #ifdef PDF_ENABLE_V8
   v8::V8::ShutdownPlatform();
   delete platform_;
 #endif  // PDF_ENABLE_V8
 }
@@ skipping 245 matching lines @@
 FPDF_PAGE EmbedderTest::GetPageTrampoline(FPDF_FORMFILLINFO* info,
                                           FPDF_DOCUMENT document,
                                           int page_index) {
   EmbedderTest* test = static_cast<EmbedderTest*>(info);
   return test->delegate_->GetPage(test->form_handle(), document, page_index);
 }
 
 // Can't use gtest-provided main since we need to stash the path to the
 // executable in order to find the external V8 binary data files.
 int main(int argc, char** argv) {
-  g_exe_path_ = argv[0];
+  g_exe_path = argv[0];
   testing::InitGoogleTest(&argc, argv);
   testing::InitGoogleMock(&argc, argv);
-  return RUN_ALL_TESTS();
+  int ret_val = RUN_ALL_TESTS();
+
+#ifdef PDF_ENABLE_V8
+#ifdef V8_USE_EXTERNAL_STARTUP_DATA
+  if (g_v8_natives)
+    free(const_cast<char*>(g_v8_natives->data));
+  if (g_v8_snapshot)
+    free(const_cast<char*>(g_v8_snapshot->data));
+#endif  // V8_USE_EXTERNAL_STARTUP_DATA
+#endif  // PDF_ENABLE_V8
+
+  return ret_val;
 }