Fix memory leaks with V8 startup data.

testing/embedder_test.cpp

 // Copyright 2015 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "testing/embedder_test.h"
 
 #include <limits.h>
 
 #include <list>
 #include <string>
@@ skipping 44 matching lines @@
 #else
   InitializeV8ForPDFium(g_exe_path_, &platform_);
 #endif  // V8_USE_EXTERNAL_STARTUP_DATA
 #endif  // FPDF_ENABLE_V8
 }
 
 EmbedderTest::~EmbedderTest() {
 #ifdef PDF_ENABLE_V8
   v8::V8::ShutdownPlatform();
   delete platform_;
+
+#ifdef V8_USE_EXTERNAL_STARTUP_DATA
+  free(const_cast<char*>(natives_.data));

[Lei Zhang, 2016/06/20 18:57:07]

Not sure why I didn't notice the bot failure earlier / notice the failure
locally, but this doesn't work since v8::V8::SetNativesDataBlob() uses
base::CallOnce() internally. I think we'll have to tolerate at least 1 leak.

+  free(const_cast<char*>(snapshot_.data));
+#endif  // V8_USE_EXTERNAL_STARTUP_DATA
 #endif  // PDF_ENABLE_V8
 }
 
 void EmbedderTest::SetUp() {
   FPDF_LIBRARY_CONFIG config;
   config.version = 2;
   config.m_pUserFontPaths = nullptr;
   config.m_v8EmbedderSlot = 0;
   config.m_pIsolate = external_isolate_;
   FPDF_InitLibraryWithConfig(&config);
@@ skipping 242 matching lines @@
 }
 
 // Can't use gtest-provided main since we need to stash the path to the
 // executable in order to find the external V8 binary data files.
 int main(int argc, char** argv) {
   g_exe_path_ = argv[0];
   testing::InitGoogleTest(&argc, argv);
   testing::InitGoogleMock(&argc, argv);
   return RUN_ALL_TESTS();
 }