chrome/browser/about_flags.cc - Issue 2068393002: Flag for Offline Page Sharing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/about_flags.cc

Issue 2068393002: Flag for Offline Page Sharing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Edit according to Jian's comments and formatting Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/android/offline_pages/offline_page_bridge.cc » ('j') | components/offline_pages/offline_page_feature.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/about_flags.cc

diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc

index 45de8fe4fba9f5e300237bbde24f7d6cc4fc9e83..98e2f7b3155eea09ba30aee869ed24769dd31425 100644

--- a/chrome/browser/about_flags.cc

+++ b/chrome/browser/about_flags.cc

@@ -1625,6 +1625,9 @@ const FeatureEntry kFeatureEntries[] = {

IDS_FLAGS_OFFLINE_PAGES_BACKGROUND_LOADING_NAME,

IDS_FLAGS_OFFLINE_PAGES_BACKGROUND_LOADING_DESCRIPTION, kOsAndroid,

FEATURE_VALUE_TYPE(offline_pages::kOfflinePagesBackgroundLoadingFeature)},

+ {"offline-pages-sharing", IDS_FLAGS_OFFLINE_PAGES_SHARING_NAME,

+ IDS_FLAGS_OFFLINE_PAGES_SHARING_DESCRIPTION, kOsAndroid,

+ FEATURE_VALUE_TYPE(offline_pages::kOfflinePagesSharingFeature)},

#endif // defined(OS_ANDROID)

{"disallow-doc-written-script-loads",

IDS_FLAGS_DISALLOW_DOC_WRITTEN_SCRIPTS_UI_NAME,

@@ -1883,8 +1886,7 @@ const FeatureEntry kFeatureEntries[] = {

FEATURE_VALUE_TYPE(chrome::android::kImportantSitesInCBD)},

{"enable-autoplay-muted-videos",

IDS_FLAGS_ENABLE_AUTOPLAY_MUTED_VIDEOS_NAME,

- IDS_FLAGS_ENABLE_AUTOPLAY_MUTED_VIDEOS_DESCRIPTION,

- kOsAndroid,

+ IDS_FLAGS_ENABLE_AUTOPLAY_MUTED_VIDEOS_DESCRIPTION, kOsAndroid,

jianli 2016/06/16 01:10:14 Please try not to touch other unrelated parts. I k

Vivian 2016/06/16 17:02:58 Acknowledged.

SINGLE_VALUE_TYPE(switches::kEnableAutoplayMutedVideos)},

#endif

{"enable-pointer-events", // FLAGS:RECORD_UMA

@@ -1903,15 +1905,13 @@ const FeatureEntry kFeatureEntries[] = {

IDS_FLAGS_FONT_CACHE_SCALING_DESCRIPTION, kOsAll,

FEATURE_VALUE_TYPE(features::kFontCacheScaling)},

#if defined(OS_ANDROID)

- {"enable-vr-shell",

- IDS_FLAGS_ENABLE_VR_SHELL_NAME,

+ {"enable-vr-shell", IDS_FLAGS_ENABLE_VR_SHELL_NAME,

IDS_FLAGS_ENABLE_VR_SHELL_DESCRIPTION, kOsAndroid,

ENABLE_DISABLE_VALUE_TYPE(switches::kEnableVrShell,

switches::kDisableVrShell)},

#endif

- {"enable-weak-memorycache",

- IDS_FLAGS_ENABLE_WEAK_MEMORYCACHE_NAME,

+ {"enable-weak-memorycache", IDS_FLAGS_ENABLE_WEAK_MEMORYCACHE_NAME,

IDS_FLAGS_ENABLE_WEAK_MEMORYCACHE_DESCRIPTION, kOsAll,

FEATURE_VALUE_TYPE(features::kWeakMemoryCache)},

// NOTE: Adding new command-line switches requires adding corresponding