Flag for Offline Page Sharing

components/offline_pages/offline_page_feature.cc

Index: components/offline_pages/offline_page_feature.cc
diff --git a/components/offline_pages/offline_page_feature.cc b/components/offline_pages/offline_page_feature.cc
index 159ea9a862f6db89d208778a5a52178b0940b372..7443e72ec54833b29528a4e640d7ff1f38546106 100644
--- a/components/offline_pages/offline_page_feature.cc
+++ b/components/offline_pages/offline_page_feature.cc
@@ -22,9 +22,13 @@ const base::Feature kOfflinePagesBackgroundLoadingFeature {
    "OfflinePagesBackgroundLoading", base::FEATURE_DISABLED_BY_DEFAULT
 };
 
+const base::Feature kOfflinePagesSharingFeature{
+    "OfflinePagesSharing", base::FEATURE_DISABLED_BY_DEFAULT};
+
 bool IsOfflinePagesEnabled() {
   return IsOfflineBookmarksEnabled() || IsOffliningRecentPagesEnabled() ||
-         IsOfflinePagesBackgroundLoadingEnabled();
+         IsOfflinePagesBackgroundLoadingEnabled() ||
+         IsOfflinePagesSharingEnabled();

[fgorski, 2016/06/16 15:09:39]

this part bothers me a little bit. I mean: if the sharing of offline pages is
enabled, but nothing else, can we really claim that offline pages are enabled?

I think it is ok to stay like that for now, but we should discuss the meaning of
the flag in that shape.

[Vivian, 2016/06/16 17:02:58]

I agree with Filip. Even if offline pages is not enabled, the pages downloaded
before should be able to be shared. Enabling page sharing does not necessarily
means that offline pages are enabled as well. 

But Jian is the expert of flag. Waiting for Jian's thought on this.

[jianli, 2016/06/16 22:27:44]

If we enable only sharing feature but not any other offline sub-features, we
need to add sharing check in IsOfflinePagesEnabled because otherwise some
offline API might not work. We do need to refactor this piece of logic since it
is kind of confusing.

 }
 
 bool IsOfflineBookmarksEnabled() {
@@ -39,4 +43,8 @@ bool IsOfflinePagesBackgroundLoadingEnabled() {
   return base::FeatureList::IsEnabled(kOfflinePagesBackgroundLoadingFeature);
 }
 
+bool IsOfflinePagesSharingEnabled() {
+  return base::FeatureList::IsEnabled(kOfflinePagesSharingFeature);
+}
+
 }  // namespace offline_pages