Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2068393002: Flag for Offline Page Sharing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Edit according to Jian's comments and formatting Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 1607 matching lines...) Expand 10 before | Expand all | Expand 10 after
1618 SINGLE_VALUE_TYPE(switches::kEnableTabSwitcherThemeColors)}, 1618 SINGLE_VALUE_TYPE(switches::kEnableTabSwitcherThemeColors)},
1619 #endif // defined(OS_ANDROID) 1619 #endif // defined(OS_ANDROID)
1620 #if defined(OS_ANDROID) 1620 #if defined(OS_ANDROID)
1621 {"offline-bookmarks", IDS_FLAGS_OFFLINE_BOOKMARKS_NAME, 1621 {"offline-bookmarks", IDS_FLAGS_OFFLINE_BOOKMARKS_NAME,
1622 IDS_FLAGS_OFFLINE_BOOKMARKS_DESCRIPTION, kOsAndroid, 1622 IDS_FLAGS_OFFLINE_BOOKMARKS_DESCRIPTION, kOsAndroid,
1623 FEATURE_VALUE_TYPE(offline_pages::kOfflineBookmarksFeature)}, 1623 FEATURE_VALUE_TYPE(offline_pages::kOfflineBookmarksFeature)},
1624 {"offline-pages-background-loading", 1624 {"offline-pages-background-loading",
1625 IDS_FLAGS_OFFLINE_PAGES_BACKGROUND_LOADING_NAME, 1625 IDS_FLAGS_OFFLINE_PAGES_BACKGROUND_LOADING_NAME,
1626 IDS_FLAGS_OFFLINE_PAGES_BACKGROUND_LOADING_DESCRIPTION, kOsAndroid, 1626 IDS_FLAGS_OFFLINE_PAGES_BACKGROUND_LOADING_DESCRIPTION, kOsAndroid,
1627 FEATURE_VALUE_TYPE(offline_pages::kOfflinePagesBackgroundLoadingFeature)}, 1627 FEATURE_VALUE_TYPE(offline_pages::kOfflinePagesBackgroundLoadingFeature)},
1628 {"offline-pages-sharing", IDS_FLAGS_OFFLINE_PAGES_SHARING_NAME,
1629 IDS_FLAGS_OFFLINE_PAGES_SHARING_DESCRIPTION, kOsAndroid,
1630 FEATURE_VALUE_TYPE(offline_pages::kOfflinePagesSharingFeature)},
1628 #endif // defined(OS_ANDROID) 1631 #endif // defined(OS_ANDROID)
1629 {"disallow-doc-written-script-loads", 1632 {"disallow-doc-written-script-loads",
1630 IDS_FLAGS_DISALLOW_DOC_WRITTEN_SCRIPTS_UI_NAME, 1633 IDS_FLAGS_DISALLOW_DOC_WRITTEN_SCRIPTS_UI_NAME,
1631 IDS_FLAGS_DISALLOW_DOC_WRITTEN_SCRIPTS_UI_DESCRIPTION, kOsAll, 1634 IDS_FLAGS_DISALLOW_DOC_WRITTEN_SCRIPTS_UI_DESCRIPTION, kOsAll,
1632 // NOTE: if we want to add additional experiment entries for other 1635 // NOTE: if we want to add additional experiment entries for other
1633 // features controlled by kBlinkSettings, we'll need to add logic to 1636 // features controlled by kBlinkSettings, we'll need to add logic to
1634 // merge the flag values. 1637 // merge the flag values.
1635 SINGLE_VALUE_TYPE_AND_VALUE( 1638 SINGLE_VALUE_TYPE_AND_VALUE(
1636 switches::kBlinkSettings, 1639 switches::kBlinkSettings,
1637 "disallowFetchForDocWrittenScriptsInMainFrame=true")}, 1640 "disallowFetchForDocWrittenScriptsInMainFrame=true")},
(...skipping 238 matching lines...) Expand 10 before | Expand all | Expand 10 after
1876 #endif 1879 #endif
1877 #if defined(OS_ANDROID) 1880 #if defined(OS_ANDROID)
1878 {"media-style-notification", IDS_FLAGS_MEDIA_STYLE_NOTIFICATION_NAME, 1881 {"media-style-notification", IDS_FLAGS_MEDIA_STYLE_NOTIFICATION_NAME,
1879 IDS_FLAGS_MEDIA_STYLE_NOTIFICATION_DESCRIPTION, kOsAndroid, 1882 IDS_FLAGS_MEDIA_STYLE_NOTIFICATION_DESCRIPTION, kOsAndroid,
1880 FEATURE_VALUE_TYPE(chrome::android::kMediaStyleNotification)}, 1883 FEATURE_VALUE_TYPE(chrome::android::kMediaStyleNotification)},
1881 {"important-sites-in-cbd", IDS_FLAGS_IMPORTANT_SITES_IN_CBD_NAME, 1884 {"important-sites-in-cbd", IDS_FLAGS_IMPORTANT_SITES_IN_CBD_NAME,
1882 IDS_FLAGS_IMPORTANT_SITES_IN_CBD_DESCRIPTION, kOsAndroid, 1885 IDS_FLAGS_IMPORTANT_SITES_IN_CBD_DESCRIPTION, kOsAndroid,
1883 FEATURE_VALUE_TYPE(chrome::android::kImportantSitesInCBD)}, 1886 FEATURE_VALUE_TYPE(chrome::android::kImportantSitesInCBD)},
1884 {"enable-autoplay-muted-videos", 1887 {"enable-autoplay-muted-videos",
1885 IDS_FLAGS_ENABLE_AUTOPLAY_MUTED_VIDEOS_NAME, 1888 IDS_FLAGS_ENABLE_AUTOPLAY_MUTED_VIDEOS_NAME,
1886 IDS_FLAGS_ENABLE_AUTOPLAY_MUTED_VIDEOS_DESCRIPTION, 1889 IDS_FLAGS_ENABLE_AUTOPLAY_MUTED_VIDEOS_DESCRIPTION, kOsAndroid,
jianli 2016/06/16 01:10:14 Please try not to touch other unrelated parts. I k
Vivian 2016/06/16 17:02:58 Acknowledged.
1887 kOsAndroid,
1888 SINGLE_VALUE_TYPE(switches::kEnableAutoplayMutedVideos)}, 1890 SINGLE_VALUE_TYPE(switches::kEnableAutoplayMutedVideos)},
1889 #endif 1891 #endif
1890 {"enable-pointer-events", // FLAGS:RECORD_UMA 1892 {"enable-pointer-events", // FLAGS:RECORD_UMA
1891 IDS_FLAGS_EXPERIMENTAL_POINTER_EVENT_NAME, 1893 IDS_FLAGS_EXPERIMENTAL_POINTER_EVENT_NAME,
1892 IDS_FLAGS_EXPERIMENTAL_POINTER_EVENT_DESCRIPTION, kOsAll, 1894 IDS_FLAGS_EXPERIMENTAL_POINTER_EVENT_DESCRIPTION, kOsAll,
1893 FEATURE_VALUE_TYPE(features::kPointerEvents)}, 1895 FEATURE_VALUE_TYPE(features::kPointerEvents)},
1894 {"passive-listener-default", // FLAGS:RECORD_UMA 1896 {"passive-listener-default", // FLAGS:RECORD_UMA
1895 IDS_FLAGS_PASSIVE_EVENT_LISTENER_DEFAULT_NAME, 1897 IDS_FLAGS_PASSIVE_EVENT_LISTENER_DEFAULT_NAME,
1896 IDS_FLAGS_PASSIVE_EVENT_LISTENER_DEFAULT_DESCRIPTION, kOsAll, 1898 IDS_FLAGS_PASSIVE_EVENT_LISTENER_DEFAULT_DESCRIPTION, kOsAll,
1897 MULTI_VALUE_TYPE(kPassiveListenersChoices)}, 1899 MULTI_VALUE_TYPE(kPassiveListenersChoices)},
1898 {"enable-loading-ipc-optimization-for-small-resources", 1900 {"enable-loading-ipc-optimization-for-small-resources",
1899 IDS_FLAGS_OPTIMIZE_LOADING_IPC_FOR_SMALL_RESOURCES_NAME, 1901 IDS_FLAGS_OPTIMIZE_LOADING_IPC_FOR_SMALL_RESOURCES_NAME,
1900 IDS_FLAGS_OPTIMIZE_LOADING_IPC_FOR_SMALL_RESOURCES_DESCRIPTION, kOsAll, 1902 IDS_FLAGS_OPTIMIZE_LOADING_IPC_FOR_SMALL_RESOURCES_DESCRIPTION, kOsAll,
1901 FEATURE_VALUE_TYPE(features::kOptimizeLoadingIPCForSmallResources)}, 1903 FEATURE_VALUE_TYPE(features::kOptimizeLoadingIPCForSmallResources)},
1902 {"enable-font-cache-scaling", IDS_FLAGS_FONT_CACHE_SCALING_NAME, 1904 {"enable-font-cache-scaling", IDS_FLAGS_FONT_CACHE_SCALING_NAME,
1903 IDS_FLAGS_FONT_CACHE_SCALING_DESCRIPTION, kOsAll, 1905 IDS_FLAGS_FONT_CACHE_SCALING_DESCRIPTION, kOsAll,
1904 FEATURE_VALUE_TYPE(features::kFontCacheScaling)}, 1906 FEATURE_VALUE_TYPE(features::kFontCacheScaling)},
1905 #if defined(OS_ANDROID) 1907 #if defined(OS_ANDROID)
1906 {"enable-vr-shell", 1908 {"enable-vr-shell", IDS_FLAGS_ENABLE_VR_SHELL_NAME,
1907 IDS_FLAGS_ENABLE_VR_SHELL_NAME,
1908 IDS_FLAGS_ENABLE_VR_SHELL_DESCRIPTION, kOsAndroid, 1909 IDS_FLAGS_ENABLE_VR_SHELL_DESCRIPTION, kOsAndroid,
1909 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableVrShell, 1910 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableVrShell,
1910 switches::kDisableVrShell)}, 1911 switches::kDisableVrShell)},
1911 #endif 1912 #endif
1912 1913
1913 {"enable-weak-memorycache", 1914 {"enable-weak-memorycache", IDS_FLAGS_ENABLE_WEAK_MEMORYCACHE_NAME,
1914 IDS_FLAGS_ENABLE_WEAK_MEMORYCACHE_NAME,
1915 IDS_FLAGS_ENABLE_WEAK_MEMORYCACHE_DESCRIPTION, kOsAll, 1915 IDS_FLAGS_ENABLE_WEAK_MEMORYCACHE_DESCRIPTION, kOsAll,
1916 FEATURE_VALUE_TYPE(features::kWeakMemoryCache)}, 1916 FEATURE_VALUE_TYPE(features::kWeakMemoryCache)},
1917 // NOTE: Adding new command-line switches requires adding corresponding 1917 // NOTE: Adding new command-line switches requires adding corresponding
1918 // entries to enum "LoginCustomFlags" in histograms.xml. See note in 1918 // entries to enum "LoginCustomFlags" in histograms.xml. See note in
1919 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. 1919 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
1920 }; 1920 };
1921 1921
1922 class FlagsStateSingleton { 1922 class FlagsStateSingleton {
1923 public: 1923 public:
1924 FlagsStateSingleton() 1924 FlagsStateSingleton()
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
2106 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2106 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2107 2107
2108 const FeatureEntry* GetFeatureEntries(size_t* count) { 2108 const FeatureEntry* GetFeatureEntries(size_t* count) {
2109 *count = arraysize(kFeatureEntries); 2109 *count = arraysize(kFeatureEntries);
2110 return kFeatureEntries; 2110 return kFeatureEntries;
2111 } 2111 }
2112 2112
2113 } // namespace testing 2113 } // namespace testing
2114 2114
2115 } // namespace about_flags 2115 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698