Rename Blink constants generated from IDL files.

Rename Blink constants generated from IDL files.

This changes the default naming scheme for Blink constants generated from IDL
files from SHOUTY_CASE_STYLE to kCamelCaseStyle. Constants declared with the
[Reflect] IDL attribute are unchanged.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/f1615358fb40347ba0df1e5bf0923fc6a3b5bdd3
Cr-Commit-Position: refs/heads/master@{#409200}

[iclelland, 2016-06-14 23:47:29]

Description was changed from

==========
Rename Blink constants generated from IDL files.

This changes the default naming scheme for Blink constants generated from IDL
files from SHOUTY_CASE_STYLE to kCamelCaseStyle. Constants declared with the
[Reflect] IDL attribute are unchanged.

BUG=
==========

to

==========
Rename Blink constants generated from IDL files.

This changes the default naming scheme for Blink constants generated from IDL
files from SHOUTY_CASE_STYLE to kCamelCaseStyle. Constants declared with the
[Reflect] IDL attribute are unchanged.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[iclelland, 2016-06-15 14:13:01]

iclelland@chromium.org changed reviewers:
+ esprehn@chromium.org

[iclelland, 2016-06-15 14:13:03]

+r esprehn: Does this make sense as a way to resolve the issue discussed in
https://groups.google.com/a/chromium.org/d/msg/platform-architecture-dev/5KHd...
?

Namely, that IDL tends to specify ALL_CAPS_CONSTANTS, which are required to be
represented in blink as well, but don't pass blink style checks anymore.

There are certainly more such constants in blink, but this takes care of all of
the IDL-generated ones.

[Yuki, 2016-06-16 08:08:09]

yukishiino@chromium.org changed reviewers:
+ yukishiino@chromium.org

[Yuki, 2016-06-16 08:08:11]

LGTM on my side.

[haraken, 2016-06-16 08:08:47]

LGTM 2

[iclelland, 2016-07-25 20:03:18]

The CQ bit was checked by iclelland@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 20:04:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 20:04:11]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.mac
     tryserver.chromium.win
   For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-07-25 20:23:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 20:23:38]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[iclelland, 2016-07-26 15:28:51]

The CQ bit was checked by iclelland@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 15:29:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 15:29:13]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.mac
     tryserver.chromium.win
   For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-07-26 16:48:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 16:48:13]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tkent, 2016-07-27 03:23:44]

tkent@chromium.org changed reviewers:
+ haraken@chromium.org, tkent@chromium.org

[tkent, 2016-07-27 03:23:47]

https://codereview.chromium.org/2068053002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/dom/Node.h (right):

https://codereview.chromium.org/2068053002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/Node.h:157: XPATH_NAMESPACE_NODE = 13,
Can we remove XPATH_NAMESPACE_NODE?

https://codereview.chromium.org/2068053002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/Node.h:161: DOCUMENT_POSITION_EQUIVALENT =
0x00,
Rename this to kDocumentPositionEquivalent for consistency.

https://codereview.chromium.org/2068053002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/html/HTMLTrackElement.h (right):

https://codereview.chromium.org/2068053002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/html/HTMLTrackElement.h:52: TRACK_ERROR = 3
Remove Reflect=TRACK_ERROR in the IDL, and use kError.

[iclelland, 2016-07-27 14:06:08]

The CQ bit was checked by iclelland@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 14:06:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 14:06:22]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.mac
     tryserver.chromium.win
   For more details, see http://crbug.com/617627.

[iclelland, 2016-07-27 14:07:06]

Thanks, tkent -- I've made those changes, and double-checked all of the affected
header files to make sure there are no other partially-converted enums.

https://codereview.chromium.org/2068053002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/dom/Node.h (right):

https://codereview.chromium.org/2068053002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/Node.h:157: XPATH_NAMESPACE_NODE = 13,
On 2016/07/27 03:23:47, tkent wrote:
> Can we remove XPATH_NAMESPACE_NODE?

I think so -- I don't see any reason at all to keep it around. The symbol does
not exist in JS, as the comment says, and hasn't for at least 10 years. (It
didn't exist in the original generated Node object; it was only added in the
pre-idl header files back in 2006). XPathNamespace was removed in 2011, and the
last reference to this symbol in a switch statement was removed in 2013. It's
not even mentioned in any W3 or WHATWG IDL. I think it's safe to delete.

https://codereview.chromium.org/2068053002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/Node.h:161: DOCUMENT_POSITION_EQUIVALENT =
0x00,
On 2016/07/27 03:23:47, tkent wrote:
> Rename this to kDocumentPositionEquivalent for consistency.

Done.

https://codereview.chromium.org/2068053002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/html/HTMLTrackElement.h (right):

https://codereview.chromium.org/2068053002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/html/HTMLTrackElement.h:52: TRACK_ERROR = 3
On 2016/07/27 03:23:47, tkent wrote:
> Remove Reflect=TRACK_ERROR in the IDL, and use kError.

Done, thanks!

[commit-bot: I haz the power, 2016-07-27 15:32:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 15:32:23]

Dry run: This issue passed the CQ dry run.

[tkent, 2016-07-27 23:40:01]

lgtm.  But please don't land this yet.  I'll post a coding style concern to the
blink-dev thread.

[iclelland, 2016-08-02 14:12:18]

On 2016/07/27 23:40:01, tkent wrote:
> lgtm.  But please don't land this yet.  I'll post a coding style concern to
the
> blink-dev thread.

The concerns appear to have been ironed out; there's agreement from at least
Elliot, Dana, and Nico that this is the right thing to do. Thanks for getting
everyone to double-check, though.

Committing this now; after final rebase.

[iclelland, 2016-08-02 14:12:30]

The CQ bit was checked by iclelland@chromium.org

[iclelland, 2016-08-02 14:12:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, yukishiino@chromium.org, tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2068053002/#ps180001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-02 14:12:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 14:12:55]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.mac
     tryserver.chromium.win
   For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-08-02 15:58:27]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-08-02 16:00:35]

Description was changed from

==========
Rename Blink constants generated from IDL files.

This changes the default naming scheme for Blink constants generated from IDL
files from SHOUTY_CASE_STYLE to kCamelCaseStyle. Constants declared with the
[Reflect] IDL attribute are unchanged.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Rename Blink constants generated from IDL files.

This changes the default naming scheme for Blink constants generated from IDL
files from SHOUTY_CASE_STYLE to kCamelCaseStyle. Constants declared with the
[Reflect] IDL attribute are unchanged.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/f1615358fb40347ba0df1e5bf0923fc6a3b5bdd3
Cr-Commit-Position: refs/heads/master@{#409200}
==========

[commit-bot: I haz the power, 2016-08-02 16:00:39]

Patchset 10 (id:??) landed as
https://crrev.com/f1615358fb40347ba0df1e5bf0923fc6a3b5bdd3
Cr-Commit-Position: refs/heads/master@{#409200}