Rename Blink constants generated from IDL files.

third_party/WebKit/Source/core/dom/Node.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004-2011, 2014 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 117 matching lines @@
 WILL_NOT_BE_EAGERLY_TRACED_CLASS(Node);
 
 // This class represents a DOM node in the DOM tree.
 // https://dom.spec.whatwg.org/#interface-node
 class CORE_EXPORT Node : public EventTarget {
     DEFINE_WRAPPERTYPEINFO();
     friend class TreeScope;
     friend class TreeScopeAdopter;
 public:
     enum NodeType {
-        ELEMENT_NODE = 1,
-        ATTRIBUTE_NODE = 2,
-        TEXT_NODE = 3,
-        CDATA_SECTION_NODE = 4,
-        PROCESSING_INSTRUCTION_NODE = 7,
-        COMMENT_NODE = 8,
-        DOCUMENT_NODE = 9,
-        DOCUMENT_TYPE_NODE = 10,
-        DOCUMENT_FRAGMENT_NODE = 11,
+        kElementNode = 1,
+        kAttributeNode = 2,
+        kTextNode = 3,
+        kCdataSectionNode = 4,
+        kProcessingInstructionNode = 7,
+        kCommentNode = 8,
+        kDocumentNode = 9,
+        kDocumentTypeNode = 10,
+        kDocumentFragmentNode = 11,
     };
 
     // Entity, EntityReference, Notation, and XPathNamespace nodes are impossible to create in Blink.
     // But for compatibility reasons we want these enum values exist in JS, and this enum makes the bindings
-    // generation not complain about ENTITY_REFERENCE_NODE being missing from the implementation
+    // generation not complain about kEntityReferenceNode being missing from the implementation
     // while not requiring all switch(NodeType) blocks to include this deprecated constant.
     enum DeprecatedNodeType {
-        ENTITY_REFERENCE_NODE = 5,
-        ENTITY_NODE = 6,
-        NOTATION_NODE = 12,
+        kEntityReferenceNode = 5,
+        kEntityNode = 6,
+        kNotationNode = 12,
         XPATH_NAMESPACE_NODE = 13,

[tkent, 2016/07/27 03:23:47]

Can we remove XPATH_NAMESPACE_NODE?

[iclelland, 2016/07/27 14:07:06]

I think so -- I don't see any reason at all to keep it around. The symbol does
not exist in JS, as the comment says, and hasn't for at least 10 years. (It
didn't exist in the original generated Node object; it was only added in the
pre-idl header files back in 2006). XPathNamespace was removed in 2011, and the
last reference to this symbol in a switch statement was removed in 2013. It's
not even mentioned in any W3 or WHATWG IDL. I think it's safe to delete.

     };
 
     enum DocumentPosition {
         DOCUMENT_POSITION_EQUIVALENT = 0x00,

[tkent, 2016/07/27 03:23:47]

Rename this to kDocumentPositionEquivalent for consistency.

[iclelland, 2016/07/27 14:07:06]

Done.

-        DOCUMENT_POSITION_DISCONNECTED = 0x01,
-        DOCUMENT_POSITION_PRECEDING = 0x02,
-        DOCUMENT_POSITION_FOLLOWING = 0x04,
-        DOCUMENT_POSITION_CONTAINS = 0x08,
-        DOCUMENT_POSITION_CONTAINED_BY = 0x10,
-        DOCUMENT_POSITION_IMPLEMENTATION_SPECIFIC = 0x20,
+        kDocumentPositionDisconnected = 0x01,
+        kDocumentPositionPreceding = 0x02,
+        kDocumentPositionFollowing = 0x04,
+        kDocumentPositionContains = 0x08,
+        kDocumentPositionContainedBy = 0x10,
+        kDocumentPositionImplementationSpecific = 0x20,
     };
 
     // Override operator new to allocate Node subtype objects onto
     // a dedicated heap.
     GC_PLUGIN_IGNORE("crbug.com/443854")
     void* operator new(size_t size)
     {
         return allocateObject(size, false);
     }
     static void* allocateObject(size_t size, bool isEager)
@@ skipping 277 matching lines @@
     bool isInShadowTree() const { return getFlag(IsInShadowTreeFlag); }
     bool isInTreeScope() const { return getFlag(static_cast<NodeFlags>(IsConnectedFlag | IsInShadowTreeFlag)); }
 
     ElementShadow* parentElementShadow() const;
     bool isInV1ShadowTree() const;
     bool isInV0ShadowTree() const;
     bool isChildOfV1ShadowHost() const;
     bool isChildOfV0ShadowHost() const;
     ShadowRoot* v1ShadowRootOfParent() const;
 
-    bool isDocumentTypeNode() const { return getNodeType() == DOCUMENT_TYPE_NODE; }
+    bool isDocumentTypeNode() const { return getNodeType() == kDocumentTypeNode; }
     virtual bool childTypeAllowed(NodeType) const { return false; }
     unsigned countChildren() const;
 
     bool isDescendantOf(const Node*) const;
     bool contains(const Node*) const;
     bool isShadowIncludingInclusiveAncestorOf(const Node*) const;
     bool containsIncludingHostElements(const Node&) const;
     Node* commonAncestor(const Node&, ContainerNode* (*parent)(const Node&)) const;
 
     // Used to determine whether range offsets use characters or node indices.
@@ skipping 416 matching lines @@
 } // namespace blink
 
 #ifndef NDEBUG
 // Outside the WebCore namespace for ease of invocation from gdb.
 void showNode(const blink::Node*);
 void showTree(const blink::Node*);
 void showNodePath(const blink::Node*);
 #endif
 
 #endif // Node_h