third_party/WebKit/Source/modules/webdatabase/SQLTransaction.cpp - Issue 2068053002: Rename Blink constants generated from IDL files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webdatabase/SQLTransaction.cpp

Issue 2068053002: Rename Blink constants generated from IDL files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webdatabase/SQLStatementBackend.cpp ('k') | third_party/WebKit/Source/modules/webdatabase/SQLTransactionBackend.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webdatabase/SQLTransaction.cpp

diff --git a/third_party/WebKit/Source/modules/webdatabase/SQLTransaction.cpp b/third_party/WebKit/Source/modules/webdatabase/SQLTransaction.cpp

index d258e51c4370df5bdfe43fc0223050382a12b0ee..603940a10a6d6fb780434f1737b96bbf87e3f6e6 100644

--- a/third_party/WebKit/Source/modules/webdatabase/SQLTransaction.cpp

+++ b/third_party/WebKit/Source/modules/webdatabase/SQLTransaction.cpp

@@ -164,8 +164,8 @@ SQLTransactionState SQLTransaction::deliverTransactionCallback()

// Spec 4.3.2 5: If the transaction callback was null or raised an exception, jump to the error callback

SQLTransactionState nextState = SQLTransactionState::RunStatements;

if (shouldDeliverErrorCallback) {

- m_database->reportStartTransactionResult(5, SQLError::UNKNOWN_ERR, 0);

- m_transactionError = SQLErrorData::create(SQLError::UNKNOWN_ERR, "the SQLTransactionCallback was null or threw an exception");

+ m_database->reportStartTransactionResult(5, SQLError::kUnknownErr, 0);

+ m_transactionError = SQLErrorData::create(SQLError::kUnknownErr, "the SQLTransactionCallback was null or threw an exception");

nextState = SQLTransactionState::DeliverTransactionErrorCallback;

}

m_database->reportStartTransactionResult(0, -1, 0); // OK

@@ -215,8 +215,8 @@ SQLTransactionState SQLTransaction::deliverStatementCallback()

m_executeSqlAllowed = false;

if (result) {

- m_database->reportCommitTransactionResult(2, SQLError::UNKNOWN_ERR, 0);

- m_transactionError = SQLErrorData::create(SQLError::UNKNOWN_ERR, "the statement callback raised an exception or statement error callback did not return false");

+ m_database->reportCommitTransactionResult(2, SQLError::kUnknownErr, 0);

+ m_transactionError = SQLErrorData::create(SQLError::kUnknownErr, "the statement callback raised an exception or statement error callback did not return false");

return nextStateForTransactionError();

}

return SQLTransactionState::RunStatements;