Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2067283003: Apply canonicalizations to path GrShapes. (Closed)

Created:
4 years, 6 months ago by bsalomon
Modified:
4 years, 6 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@intermediate_grshape
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Apply canonicalizations to path GrShapes. The following canonicalizations of path-backed GrShapes are added: *convex shapes are stored with even/odd (or inv even/odd) fill. *filled paths are closed. *dashed paths ignore inverseness of the fill This will improve the results of queries about the geometry that will be added in a future change. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2067283003 Committed: https://skia.googlesource.com/skia/+/93f66bc3af522fdd2a5315407ba6d3f65c13fd1c

Patch Set 1 #

Patch Set 2 : fix indentation #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -14 lines) Patch
M src/gpu/GrShape.h View 3 chunks +6 lines, -2 lines 0 comments Download
M src/gpu/GrShape.cpp View 1 7 chunks +51 lines, -11 lines 1 comment Download
M tests/GrShapeTest.cpp View 2 chunks +8 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
bsalomon
https://codereview.chromium.org/2067283003/diff/20001/src/gpu/GrShape.cpp File src/gpu/GrShape.cpp (right): https://codereview.chromium.org/2067283003/diff/20001/src/gpu/GrShape.cpp#newcode329 src/gpu/GrShape.cpp:329: // There is no point in closing lines, though, ...
4 years, 6 months ago (2016-06-20 20:18:58 UTC) #4
egdaniel
lgtm
4 years, 6 months ago (2016-06-21 14:46:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2067283003/20001
4 years, 6 months ago (2016-06-21 15:16:22 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 15:35:54 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/93f66bc3af522fdd2a5315407ba6d3f65c13fd1c

Powered by Google App Engine
This is Rietveld 408576698