Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2064113004: Some simplifications of GrShape reductions/canonicalizations (Closed)

Created:
4 years, 6 months ago by bsalomon
Modified:
4 years, 6 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Some simplifications of GrShape reductions/canonicalizations GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2064113004 Committed: https://skia.googlesource.com/skia/+/1b28c1adc1e156831d5332546e942b63fd29075b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -141 lines) Patch
M src/gpu/GrShape.h View 9 chunks +12 lines, -37 lines 0 comments Download
M src/gpu/GrShape.cpp View 2 chunks +76 lines, -99 lines 0 comments Download
M tests/GrShapeTest.cpp View 1 chunk +13 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
bsalomon
The main thing here is to use an intermediate GrShape when applying reductions between PE ...
4 years, 6 months ago (2016-06-15 17:21:07 UTC) #3
bsalomon
ping
4 years, 6 months ago (2016-06-20 17:23:57 UTC) #4
egdaniel
lgtm
4 years, 6 months ago (2016-06-20 18:57:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064113004/1
4 years, 6 months ago (2016-06-20 19:12:20 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 19:28:22 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1b28c1adc1e156831d5332546e942b63fd29075b

Powered by Google App Engine
This is Rietveld 408576698