mojo/shell/in_process_dynamic_service_runner.cc - Issue 206713004: Report PPAPI plugin load error code to UMA.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/shell/in_process_dynamic_service_runner.cc

Issue 206713004: Report PPAPI plugin load error code to UMA. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Use std::string directly. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/shell/in_process_dynamic_service_runner.cc

diff --git a/mojo/shell/in_process_dynamic_service_runner.cc b/mojo/shell/in_process_dynamic_service_runner.cc

index e3661586a5003903bfe4427fa55b65f4c99cd1d5..10fc1e2f70137904e8065f042298d0e16e6bfb18 100644

--- a/mojo/shell/in_process_dynamic_service_runner.cc

+++ b/mojo/shell/in_process_dynamic_service_runner.cc

@@ -49,7 +49,7 @@ void InProcessDynamicServiceRunner::Run() {

base::Bind(base::IgnoreResult(&base::DeleteFile), app_path_, false));

do {

- std::string load_error;

+ base::NativeLibraryLoadError load_error = 0;

base::ScopedNativeLibrary app_library(

base::LoadNativeLibrary(app_path_, &load_error));

if (!app_library.is_valid()) {