Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6959)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/renderer/chrome_render_process_observer.cc

Issue 206713004: Report PPAPI plugin load error code to UMA. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use std::string directly. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/load_library_perf_test.cc ('K') | « chrome/plugin/chrome_content_plugin_client.cc ('k') | content/child/npapi/plugin_lib.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/chrome_render_process_observer.cc
diff --git a/chrome/renderer/chrome_render_process_observer.cc b/chrome/renderer/chrome_render_process_observer.cc
index e4f6d4b8390aa9762f3b4451c3c486d674560534..3bacce9c0bd5a75f34e83ae7d5d1883934b917dc 100644
--- a/chrome/renderer/chrome_render_process_observer.cc
+++ b/chrome/renderer/chrome_render_process_observer.cc
@@ -294,7 +294,7 @@ ChromeRenderProcessObserver::ChromeRenderProcessObserver(
#elif defined(OS_WIN)
// crypt32.dll is used to decode X509 certificates for Chromoting.
// Only load this library when the feature is enabled.
- std::string error;
+ base::NativeLibraryLoadError error = 0;
base::LoadNativeLibrary(base::FilePath(L"crypt32.dll"), &error);
ddorwin 2014/03/21 20:06:32 just pass NULL
xhwang 2014/03/21 22:33:28 Done.
#endif
// Setup initial set of crash dump data for Field Trials in this renderer.
« chrome/browser/load_library_perf_test.cc ('K') | « chrome/plugin/chrome_content_plugin_client.cc ('k') | content/child/npapi/plugin_lib.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698