content/zygote/zygote_main_linux.cc - Issue 206713004: Report PPAPI plugin load error code to UMA.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/zygote/zygote_main_linux.cc

Issue 206713004: Report PPAPI plugin load error code to UMA. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Use std::string directly. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/zygote/zygote_main_linux.cc

diff --git a/content/zygote/zygote_main_linux.cc b/content/zygote/zygote_main_linux.cc

index f6c32f92e000d0ecb0b137d6775bdf6daafbfae1..1dfcc5e9310fc8c54be065c66e9319f20aeb8195 100644

--- a/content/zygote/zygote_main_linux.cc

+++ b/content/zygote/zygote_main_linux.cc

@@ -292,7 +292,7 @@ void PreloadPepperPlugins() {

ComputePepperPluginList(&plugins);

for (size_t i = 0; i < plugins.size(); ++i) {

if (!plugins[i].is_internal && plugins[i].is_sandboxed) {

- std::string error;

+ base::NativeLibraryLoadError error = 0;

base::NativeLibrary library = base::LoadNativeLibrary(plugins[i].path,

&error);

VLOG_IF(1, !library) << "Unable to load plugin "