Restricting method and interface access in ChromeLauncherControllerImpl

Restricting method and interface access in ChromeLauncherControllerImpl

Making most inherited interfaces private. Also making most of the inherited
methods private.

BUG=NONE

Committed: https://crrev.com/69d1d15a506249d6d80acf5fa2f85dc9cea0625c
Cr-Commit-Position: refs/heads/master@{#399571}

[mfomitchev, 2016-06-13 19:39:28]

mfomitchev@chromium.org changed reviewers:
+ msw@chromium.org

[msw, 2016-06-13 20:54:16]

https://codereview.chromium.org/2066593002/diff/1/chrome/browser/ui/ash/launc...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h (right):

https://codereview.chromium.org/2066593002/diff/1/chrome/browser/ui/ash/launc...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h:170: //
LauncherAppUpdater:
Shouldn't this also be private to match the base class visibility? (nit: and the
actual base class is LauncherAppUpdater::Delegate)

[mfomitchev, 2016-06-13 20:58:33]

https://codereview.chromium.org/2066593002/diff/1/chrome/browser/ui/ash/launc...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h (right):

https://codereview.chromium.org/2066593002/diff/1/chrome/browser/ui/ash/launc...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h:170: //
LauncherAppUpdater:
On 2016/06/13 20:54:16, msw wrote:
> Shouldn't this also be private to match the base class visibility? (nit: and
the
> actual base class is LauncherAppUpdater::Delegate)

Changes inheritance of LauncherAppUpdater::Delegate to public (and fixed the
comment). We actually do use OnAppUpdated outside of this class.

[msw, 2016-06-13 21:02:54]

lgtm

[mfomitchev, 2016-06-13 21:34:49]

The CQ bit was checked by mfomitchev@chromium.org

[commit-bot: I haz the power, 2016-06-13 21:35:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2066593002/20001

[commit-bot: I haz the power, 2016-06-13 22:17:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-13 22:18:00]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-13 22:19:16]

Description was changed from

==========
Restricting method and interface access in ChromeLauncherControllerImpl

Making most inherited interfaces private. Also making most of the inherited
methods private.

BUG=NONE
==========

to

==========
Restricting method and interface access in ChromeLauncherControllerImpl

Making most inherited interfaces private. Also making most of the inherited
methods private.

BUG=NONE

Committed: https://crrev.com/69d1d15a506249d6d80acf5fa2f85dc9cea0625c
Cr-Commit-Position: refs/heads/master@{#399571}
==========

[commit-bot: I haz the power, 2016-06-13 22:19:17]

Patchset 2 (id:??) landed as
https://crrev.com/69d1d15a506249d6d80acf5fa2f85dc9cea0625c
Cr-Commit-Position: refs/heads/master@{#399571}