Mustash implementation of ChromeLauncherController.

Mustash implementation of ChromeLauncherController.

Adds ChromeLauncherControllerMus. The functionality is mostly stubbed out, but app launches work.

BUG=619605
Committed: https://crrev.com/b267087ed6559cf2d2e1b4f7aefb52f0f132e3c8
Cr-Commit-Position: refs/heads/master@{#399599}

[mfomitchev, 2016-06-10 20:44:46]

Description was changed from

==========
NOT FOR REVIEW: ChromeLauncherControllerMus impl.

BUG=NONE
==========

to

==========
Mustash implementation of ChromeLauncherController.

Adds ChromeLauncherControllerMus. The functionality is mostly stubbed out, but
app launches work. 

BUG=NONE
==========

[mfomitchev, 2016-06-10 20:46:15]

mfomitchev@chromium.org changed reviewers:
+ msw@chromium.org

[msw, 2016-06-10 22:58:44]

lgtm with nits; you should use a bug number for this and the interface split,
even if it's just the shelf/applist meta bug.

https://codereview.chromium.org/2059963002/diff/1/chrome/browser/ui/ash/launc...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc (right):

https://codereview.chromium.org/2059963002/diff/1/chrome/browser/ui/ash/launc...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc:101:
shelf_controller_->LaunchItem(app_id);
nit: inline ChromeMashShelfController::instance() and remove |shelf_controller_|

https://codereview.chromium.org/2059963002/diff/1/chrome/browser/ui/ash/launc...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.h (right):

https://codereview.chromium.org/2059963002/diff/1/chrome/browser/ui/ash/launc...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.h:15: // Create
ChromeLauncherControllerMus instance and set is as the
nit: "Create a" and "set it"

[mfomitchev, 2016-06-13 15:55:19]

Description was changed from

==========
Mustash implementation of ChromeLauncherController.

Adds ChromeLauncherControllerMus. The functionality is mostly stubbed out, but
app launches work. 

BUG=NONE
==========

to

==========
Mustash implementation of ChromeLauncherController.

Adds ChromeLauncherControllerMus. The functionality is mostly stubbed out, but
app launches work. 

BUG=619605
==========

[mfomitchev, 2016-06-13 20:50:13]

https://codereview.chromium.org/2059963002/diff/1/chrome/browser/ui/ash/launc...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc (right):

https://codereview.chromium.org/2059963002/diff/1/chrome/browser/ui/ash/launc...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc:101:
shelf_controller_->LaunchItem(app_id);
On 2016/06/10 22:58:44, msw wrote:
> nit: inline ChromeMashShelfController::instance() and remove
|shelf_controller_|

As discussed, changed this so that ChromeLauncherControllerMus owns
ChromeMashShelfController.

https://codereview.chromium.org/2059963002/diff/1/chrome/browser/ui/ash/launc...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.h (right):

https://codereview.chromium.org/2059963002/diff/1/chrome/browser/ui/ash/launc...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.h:15: // Create
ChromeLauncherControllerMus instance and set is as the
On 2016/06/10 22:58:44, msw wrote:
> nit: "Create a" and "set it"

Done.

[msw, 2016-06-13 21:01:22]

https://codereview.chromium.org/2059963002/diff/30001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc (right):

https://codereview.chromium.org/2059963002/diff/30001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc:13:
ChromeLauncherControllerMus* instance = new ChromeLauncherControllerMus();
Perhaps this should call Init() on the new instance after construction?

https://codereview.chromium.org/2059963002/diff/30001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/chrome_mash_shelf_controller.cc (left):

https://codereview.chromium.org/2059963002/diff/30001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/chrome_mash_shelf_controller.cc:65:
instance_->Init();
You'll need to call Init() at some point. Inline it in the ctor, call it from
the ctor, or call it from the ChromeLauncherControllerMus ctor (or that class'
Init if you call that anywhere)

[mfomitchev, 2016-06-13 21:33:31]

https://codereview.chromium.org/2059963002/diff/30001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc (right):

https://codereview.chromium.org/2059963002/diff/30001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc:13:
ChromeLauncherControllerMus* instance = new ChromeLauncherControllerMus();
On 2016/06/13 21:01:22, msw wrote:
> Perhaps this should call Init() on the new instance after construction?

I added it into InitializeMash(). ChromeLauncherControllerImpl doesn't call
Init() in CreateInstance(), so we probably shouldn't do it in the Mus version
either.

https://codereview.chromium.org/2059963002/diff/30001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/chrome_mash_shelf_controller.cc (left):

https://codereview.chromium.org/2059963002/diff/30001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/chrome_mash_shelf_controller.cc:65:
instance_->Init();
On 2016/06/13 21:01:22, msw wrote:
> You'll need to call Init() at some point. Inline it in the ctor, call it from
> the ctor, or call it from the ChromeLauncherControllerMus ctor (or that class'
> Init if you call that anywhere)

Oops! Thanks, done.

[msw, 2016-06-13 21:36:41]

lgtm

[mfomitchev, 2016-06-13 22:22:06]

The CQ bit was checked by mfomitchev@chromium.org

[commit-bot: I haz the power, 2016-06-13 22:22:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2059963002/70001

[commit-bot: I haz the power, 2016-06-13 23:39:06]

Description was changed from

==========
Mustash implementation of ChromeLauncherController.

Adds ChromeLauncherControllerMus. The functionality is mostly stubbed out, but
app launches work. 

BUG=619605
==========

to

==========
Mustash implementation of ChromeLauncherController.

Adds ChromeLauncherControllerMus. The functionality is mostly stubbed out, but
app launches work. 

BUG=619605
==========

[commit-bot: I haz the power, 2016-06-13 23:39:07]

Committed patchset #5 (id:70001)

[commit-bot: I haz the power, 2016-06-13 23:39:10]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-13 23:40:40]

Description was changed from

==========
Mustash implementation of ChromeLauncherController.

Adds ChromeLauncherControllerMus. The functionality is mostly stubbed out, but
app launches work. 

BUG=619605
==========

to

==========
Mustash implementation of ChromeLauncherController.

Adds ChromeLauncherControllerMus. The functionality is mostly stubbed out, but
app launches work.

BUG=619605

Committed: https://crrev.com/b267087ed6559cf2d2e1b4f7aefb52f0f132e3c8
Cr-Commit-Position: refs/heads/master@{#399599}
==========

[commit-bot: I haz the power, 2016-06-13 23:40:41]

Patchset 5 (id:??) landed as
https://crrev.com/b267087ed6559cf2d2e1b4f7aefb52f0f132e3c8
Cr-Commit-Position: refs/heads/master@{#399599}