Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h

Issue 2066593002: Restricting method and interface access in ChromeLauncherControllerImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@launcher_controller_GetAppIDForShelfIDConst
Patch Set: public inheritance for LauncherAppUpdater::Delegate Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h
diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h
index b8d8a2b536fc82d2c0754bd2e97f68d7abcf1d53..feb9eac75381f2a1b1cc4010f154b219508e7227 100644
--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h
+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h
@@ -57,12 +57,12 @@ class ChromeLauncherControllerUserSwitchObserver;
class ChromeLauncherControllerImpl
: public ChromeLauncherController,
public ash::ShelfDelegate,
- public ash::ShelfModelObserver,
- public ash::WindowTreeHostManager::Observer,
- public AppIconLoaderDelegate,
- public AppSyncUIStateObserver,
public LauncherAppUpdater::Delegate,
- public ash::ShelfItemDelegateManagerObserver {
+ private ash::ShelfModelObserver,
+ private ash::WindowTreeHostManager::Observer,
+ private AppIconLoaderDelegate,
+ private AppSyncUIStateObserver,
+ private ash::ShelfItemDelegateManagerObserver {
public:
ChromeLauncherControllerImpl(Profile* profile, ash::ShelfModel* model);
~ChromeLauncherControllerImpl() override;
@@ -167,20 +167,7 @@ class ChromeLauncherControllerImpl
bool IsAppPinned(const std::string& app_id) override;
void UnpinAppWithID(const std::string& app_id) override;
- // ash::ShelfItemDelegateManagerObserver:
- void OnSetShelfItemDelegate(ash::ShelfID id,
- ash::ShelfItemDelegate* item_delegate) override;
-
- // ash::ShelfModelObserver:
- void ShelfItemAdded(int index) override;
- void ShelfItemRemoved(int index, ash::ShelfID id) override;
- void ShelfItemMoved(int start_index, int target_index) override;
- void ShelfItemChanged(int index, const ash::ShelfItem& old_item) override;
-
- // ash::WindowTreeHostManager::Observer:
- void OnDisplayConfigurationChanged() override;
-
- // LauncherAppUpdater:
+ // LauncherAppUpdater::Delegate:
void OnAppInstalled(content::BrowserContext* browser_context,
const std::string& app_id) override;
void OnAppUpdated(content::BrowserContext* browser_context,
@@ -188,15 +175,6 @@ class ChromeLauncherControllerImpl
void OnAppUninstalled(content::BrowserContext* browser_context,
const std::string& app_id) override;
- // AppSyncUIStateObserver:
- void OnAppSyncUIStatusChanged() override;
-
- // AppIconLoaderDelegate:
- void OnAppImageUpdated(const std::string& app_id,
- const gfx::ImageSkia& image) override;
-
-
-
protected:
// Creates a new app shortcut item and controller on the shelf at |index|.
// Use kInsertItemAtEnd to add a shortcut as the last item.
@@ -218,6 +196,7 @@ class ChromeLauncherControllerImpl
friend class ChromeLauncherControllerImplTest;
friend class ShelfAppBrowserTest;
friend class LauncherPlatformAppBrowserTest;
+ FRIEND_TEST_ALL_PREFIXES(ChromeLauncherControllerImplTest, AppPanels);
typedef std::map<ash::ShelfID, LauncherItemController*> IDToItemControllerMap;
typedef std::map<content::WebContents*, std::string> WebContentsToAppIDMap;
@@ -330,6 +309,26 @@ class ChromeLauncherControllerImpl
AppIconLoader* GetAppIconLoaderForApp(const std::string& app_id);
+ // ash::ShelfItemDelegateManagerObserver:
+ void OnSetShelfItemDelegate(ash::ShelfID id,
+ ash::ShelfItemDelegate* item_delegate) override;
+
+ // ash::ShelfModelObserver:
+ void ShelfItemAdded(int index) override;
+ void ShelfItemRemoved(int index, ash::ShelfID id) override;
+ void ShelfItemMoved(int start_index, int target_index) override;
+ void ShelfItemChanged(int index, const ash::ShelfItem& old_item) override;
+
+ // ash::WindowTreeHostManager::Observer:
+ void OnDisplayConfigurationChanged() override;
+
+ // AppSyncUIStateObserver:
+ void OnAppSyncUIStatusChanged() override;
+
+ // AppIconLoaderDelegate:
+ void OnAppImageUpdated(const std::string& app_id,
+ const gfx::ImageSkia& image) override;
+
ash::ShelfModel* model_;
ash::ShelfItemDelegateManager* item_delegate_manager_;
« no previous file with comments | « no previous file | chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698