Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2066583004: mash: Move most files in //ash/system/tray to //ash/common/system/tray (Closed)

Created:
4 years, 6 months ago by James Cook
Modified:
4 years, 6 months ago
Reviewers:
msw
CC:
chromium-reviews, sadrul, dtseng+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@trayupdatemove
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Move most files in //ash/system/tray to //ash/common/system/tray None of these files have aura or ash::Shell dependencies, but many of them are dependencies of other files I'm trying to move. This is a mechanical change: move_source_file.py ash/system/tray/actionable_view.h ash/common/system/tray/ move_source_file.py ash/system/tray/actionable_view.cc ash/common/system/tray/ move_source_file.py ash/system/tray/fixed_sized_scroll_view.h ash/common/system/tray/ move_source_file.py ash/system/tray/fixed_sized_scroll_view.cc ash/common/system/tray/ move_source_file.py ash/system/tray/hover_highlight_view.h ash/common/system/tray/ move_source_file.py ash/system/tray/hover_highlight_view.cc ash/common/system/tray/ move_source_file.py ash/system/tray/special_popup_row.h ash/common/system/tray/ move_source_file.py ash/system/tray/special_popup_row.cc ash/common/system/tray/ move_source_file.py ash/system/tray/throbber_view.h ash/common/system/tray/ move_source_file.py ash/system/tray/throbber_view.cc ash/common/system/tray/ move_source_file.py ash/system/tray/tray_bar_button_with_title.h ash/common/system/tray/ move_source_file.py ash/system/tray/tray_bar_button_with_title.cc ash/common/system/tray/ move_source_file.py ash/system/tray/tray_empty.h ash/common/system/tray/ move_source_file.py ash/system/tray/tray_empty.cc ash/common/system/tray/ move_source_file.py ash/system/tray/tray_item_more.h ash/common/system/tray/ move_source_file.py ash/system/tray/tray_item_more.cc ash/common/system/tray/ move_source_file.py ash/system/tray/tray_notification_view.h ash/common/system/tray/ move_source_file.py ash/system/tray/tray_notification_view.cc ash/common/system/tray/ move_source_file.py ash/system/tray/tray_popup_header_button.h ash/common/system/tray/ move_source_file.py ash/system/tray/tray_popup_header_button.cc ash/common/system/tray/ move_source_file.py ash/system/tray/tray_popup_item_container.h ash/common/system/tray/ move_source_file.py ash/system/tray/tray_popup_item_container.cc ash/common/system/tray/ move_source_file.py ash/system/tray/tray_popup_label_button_border.h ash/common/system/tray/ move_source_file.py ash/system/tray/tray_popup_label_button_border.cc ash/common/system/tray/ move_source_file.py ash/system/tray/tray_popup_label_button.h ash/common/system/tray/ move_source_file.py ash/system/tray/tray_popup_label_button.cc ash/common/system/tray/ move_source_file.py ash/system/tray/view_click_listener.h ash/common/system/tray/ I also removed a few unnecessary includes of base/compiler_specific.h. BUG=619636 TEST=compiles TBR=stevenjb@chromium.org for mechanical changes to //chrome/browser/chromeos Committed: https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac Cr-Commit-Position: refs/heads/master@{#399628}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -2294 lines) Patch
M ash/ash.gyp View 2 chunks +27 lines, -27 lines 0 comments Download
A + ash/common/system/tray/actionable_view.h View 2 chunks +3 lines, -4 lines 0 comments Download
A + ash/common/system/tray/actionable_view.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/system/tray/fixed_sized_scroll_view.h View 2 chunks +3 lines, -4 lines 0 comments Download
A + ash/common/system/tray/fixed_sized_scroll_view.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/system/tray/hover_highlight_view.h View 2 chunks +4 lines, -5 lines 0 comments Download
A + ash/common/system/tray/hover_highlight_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + ash/common/system/tray/special_popup_row.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/system/tray/special_popup_row.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + ash/common/system/tray/throbber_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/system/tray/throbber_view.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/system/tray/tray_bar_button_with_title.h View 2 chunks +3 lines, -4 lines 0 comments Download
A + ash/common/system/tray/tray_bar_button_with_title.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/system/tray/tray_empty.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/system/tray/tray_empty.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + ash/common/system/tray/tray_item_more.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ash/common/system/tray/tray_item_more.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/system/tray/tray_notification_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/system/tray/tray_notification_view.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/system/tray/tray_popup_header_button.h View 2 chunks +3 lines, -4 lines 0 comments Download
A + ash/common/system/tray/tray_popup_header_button.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/system/tray/tray_popup_item_container.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/system/tray/tray_popup_item_container.cc View 1 chunk +1 line, -2 lines 0 comments Download
A + ash/common/system/tray/tray_popup_label_button.h View 2 chunks +3 lines, -4 lines 0 comments Download
A + ash/common/system/tray/tray_popup_label_button.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + ash/common/system/tray/tray_popup_label_button_border.h View 2 chunks +3 lines, -4 lines 0 comments Download
A + ash/common/system/tray/tray_popup_label_button_border.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/system/tray/view_click_listener.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/system/audio/tray_audio.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/system/audio/volume_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/audio/volume_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/cast/tray_cast.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M ash/system/chromeos/audio/audio_detailed_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/audio/audio_detailed_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/bluetooth/tray_bluetooth.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M ash/system/chromeos/enterprise/tray_enterprise.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/label_tray_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/network/network_state_list_detailed_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/network/network_state_list_detailed_view.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M ash/system/chromeos/network/tray_network.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/system/chromeos/network/tray_sms.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/system/chromeos/network/tray_vpn.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/network/vpn_list_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/network/vpn_list_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/screen_security/screen_tray_item.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/settings/tray_settings.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/system/chromeos/supervised/tray_supervised_user.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/supervised/tray_supervised_user.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/tray_caps_lock.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/tray_display.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/tray_tracing.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/date/date_default_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/date/date_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/ime/tray_ime_chromeos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D ash/system/tray/actionable_view.h View 1 chunk +0 lines, -66 lines 0 comments Download
D ash/system/tray/actionable_view.cc View 1 chunk +0 lines, -93 lines 0 comments Download
D ash/system/tray/fixed_sized_scroll_view.h View 1 chunk +0 lines, -44 lines 0 comments Download
D ash/system/tray/fixed_sized_scroll_view.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D ash/system/tray/hover_highlight_view.h View 1 chunk +0 lines, -119 lines 0 comments Download
D ash/system/tray/hover_highlight_view.cc View 1 chunk +0 lines, -251 lines 0 comments Download
D ash/system/tray/special_popup_row.h View 1 chunk +0 lines, -52 lines 0 comments Download
D ash/system/tray/special_popup_row.cc View 1 chunk +0 lines, -137 lines 0 comments Download
M ash/system/tray/system_tray_bubble.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/system_tray_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/system/tray/throbber_view.h View 1 chunk +0 lines, -64 lines 0 comments Download
D ash/system/tray/throbber_view.cc View 1 chunk +0 lines, -101 lines 0 comments Download
M ash/system/tray/tray_background_view.h View 1 chunk +1 line, -1 line 0 comments Download
D ash/system/tray/tray_bar_button_with_title.h View 1 chunk +0 lines, -47 lines 0 comments Download
D ash/system/tray/tray_bar_button_with_title.cc View 1 chunk +0 lines, -112 lines 0 comments Download
M ash/system/tray/tray_details_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_details_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_details_view_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
D ash/system/tray/tray_empty.h View 1 chunk +0 lines, -33 lines 0 comments Download
D ash/system/tray/tray_empty.cc View 1 chunk +0 lines, -65 lines 0 comments Download
D ash/system/tray/tray_item_more.h View 1 chunk +0 lines, -61 lines 0 comments Download
D ash/system/tray/tray_item_more.cc View 1 chunk +0 lines, -106 lines 0 comments Download
D ash/system/tray/tray_notification_view.h View 1 chunk +0 lines, -91 lines 0 comments Download
D ash/system/tray/tray_notification_view.cc View 1 chunk +0 lines, -166 lines 0 comments Download
D ash/system/tray/tray_popup_header_button.h View 1 chunk +0 lines, -42 lines 0 comments Download
D ash/system/tray/tray_popup_header_button.cc View 1 chunk +0 lines, -65 lines 0 comments Download
D ash/system/tray/tray_popup_item_container.h View 1 chunk +0 lines, -52 lines 0 comments Download
D ash/system/tray/tray_popup_item_container.cc View 1 chunk +0 lines, -89 lines 0 comments Download
D ash/system/tray/tray_popup_label_button.h View 1 chunk +0 lines, -28 lines 0 comments Download
D ash/system/tray/tray_popup_label_button.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D ash/system/tray/tray_popup_label_button_border.h View 1 chunk +0 lines, -30 lines 0 comments Download
D ash/system/tray/tray_popup_label_button_border.cc View 1 chunk +0 lines, -99 lines 0 comments Download
D ash/system/tray/view_click_listener.h View 1 chunk +0 lines, -24 lines 0 comments Download
M ash/system/tray_accessibility.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/tray_accessibility.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/system/user/user_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/shutdown_policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/ui/focus_ring_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Issue 2064953002 Patch 20001

Messages

Total messages: 13 (7 generated)
James Cook
msw, can I get a rubber-stamp? 6 of these files are dependencies of the tray ...
4 years, 6 months ago (2016-06-13 22:43:38 UTC) #3
msw
lgtm
4 years, 6 months ago (2016-06-13 22:59:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066583004/20001
4 years, 6 months ago (2016-06-14 00:01:06 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-14 01:04:04 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-14 01:04:16 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 01:05:28 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac
Cr-Commit-Position: refs/heads/master@{#399628}

Powered by Google App Engine
This is Rietveld 408576698