mash: Migrate tray date view to //ash/common types

mash: Migrate tray date view to //ash/common types

This eliminates ash::Shell dependencies.

* Move clock observers to WmSystemTrayNotifier
* Move metrics to WmUserMetricsAction
* Add RequestShutdown() to SystemTrayDelegate to avoid dependency on
LockStateController

BUG=619636
TEST=existing ash_unittests

Committed: https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912
Cr-Commit-Position: refs/heads/master@{#399747}

[James Cook, 2016-06-13 23:55:12]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-06-13 23:55:12]

msw, please take a look.

I'll do the file move to //ash/common in a separate CL.

[msw, 2016-06-14 00:18:26]

https://codereview.chromium.org/2064953002/diff/1/ash/common/system/tray/wm_s...
File ash/common/system/tray/wm_system_tray_notifier.cc (right):

https://codereview.chromium.org/2064953002/diff/1/ash/common/system/tray/wm_s...
ash/common/system/tray/wm_system_tray_notifier.cc:37: void
WmSystemTrayNotifier::NotifyRefreshClock() {
nit: order these three functions before NotifyUpdateRecommended (match decl)

https://codereview.chromium.org/2064953002/diff/1/ash/metrics/user_metrics_re...
File ash/metrics/user_metrics_recorder.cc (right):

https://codereview.chromium.org/2064953002/diff/1/ash/metrics/user_metrics_re...
ash/metrics/user_metrics_recorder.cc:590: case
wm::WmUserMetricsAction::TRAY_HELP:
Why are we moving these metrics enum values in a piecemeal fashion?
(what makes a value Wm* compatible or not? can we move them all at once?)

https://codereview.chromium.org/2064953002/diff/1/ash/system/date/date_view.h
File ash/system/date/date_view.h (right):

https://codereview.chromium.org/2064953002/diff/1/ash/system/date/date_view.h...
ash/system/date/date_view.h:15: #include "base/time/time.h"
Isn't base/timer/timer.h needed for |base::OneShotTimer timer_;|?

[James Cook, 2016-06-14 16:54:07]

msw, please take another look

https://codereview.chromium.org/2064953002/diff/1/ash/common/system/tray/wm_s...
File ash/common/system/tray/wm_system_tray_notifier.cc (right):

https://codereview.chromium.org/2064953002/diff/1/ash/common/system/tray/wm_s...
ash/common/system/tray/wm_system_tray_notifier.cc:37: void
WmSystemTrayNotifier::NotifyRefreshClock() {
On 2016/06/14 00:18:26, msw wrote:
> nit: order these three functions before NotifyUpdateRecommended (match decl)

Done.

https://codereview.chromium.org/2064953002/diff/1/ash/metrics/user_metrics_re...
File ash/metrics/user_metrics_recorder.cc (right):

https://codereview.chromium.org/2064953002/diff/1/ash/metrics/user_metrics_re...
ash/metrics/user_metrics_recorder.cc:590: case
wm::WmUserMetricsAction::TRAY_HELP:
On 2016/06/14 00:18:26, msw wrote:
> Why are we moving these metrics enum values in a piecemeal fashion?
> (what makes a value Wm* compatible or not? can we move them all at once?)

Good point. I think this dates back to when the window manager was a separate
binary.

How about I collapse the Wm and non-Wm versions of all these enums into a single
enum in a header file in //ash/common/metrics/? What do you think of just
calling it ash::UserMetricsAction?  (There's already a user_metrics_action.h in
//base/metrics, but it's in namespace base::.) Alternately, ash::UserMetric?

If that sounds good I'll do a separate CL that moves everything.

(And BTW I really appreciate that you pick up on "why are we doing this?" issues
like this.)

https://codereview.chromium.org/2064953002/diff/1/ash/system/date/date_view.h
File ash/system/date/date_view.h (right):

https://codereview.chromium.org/2064953002/diff/1/ash/system/date/date_view.h...
ash/system/date/date_view.h:15: #include "base/time/time.h"
On 2016/06/14 00:18:26, msw wrote:
> Isn't base/timer/timer.h needed for |base::OneShotTimer timer_;|?

Whoops. I put it back and forward-declared base::Time.

[msw, 2016-06-14 17:08:51]

lgtm

https://codereview.chromium.org/2064953002/diff/1/ash/metrics/user_metrics_re...
File ash/metrics/user_metrics_recorder.cc (right):

https://codereview.chromium.org/2064953002/diff/1/ash/metrics/user_metrics_re...
ash/metrics/user_metrics_recorder.cc:590: case
wm::WmUserMetricsAction::TRAY_HELP:
On 2016/06/14 16:54:07, James Cook wrote:
> On 2016/06/14 00:18:26, msw wrote:
> > Why are we moving these metrics enum values in a piecemeal fashion?
> > (what makes a value Wm* compatible or not? can we move them all at once?)
> 
> Good point. I think this dates back to when the window manager was a separate
> binary.
> 
> How about I collapse the Wm and non-Wm versions of all these enums into a
single
> enum in a header file in //ash/common/metrics/? What do you think of just
> calling it ash::UserMetricsAction?  (There's already a user_metrics_action.h
in
> //base/metrics, but it's in namespace base::.) Alternately, ash::UserMetric?
> 
> If that sounds good I'll do a separate CL that moves everything.
> 
> (And BTW I really appreciate that you pick up on "why are we doing this?"
issues
> like this.)

sgtm with ash::UserMetricsAction (current non-common name)

[James Cook, 2016-06-14 17:52:58]

I'm going to land this, then do the CL to move the UMA enums.

[James Cook, 2016-06-14 18:03:23]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-06-14 18:03:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2064953002/60001

[commit-bot: I haz the power, 2016-06-14 18:08:50]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-14 18:08:53]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-14 18:10:56]

Description was changed from

==========
mash: Migrate tray date view to //ash/common types

This eliminates ash::Shell dependencies.

* Move clock observers to WmSystemTrayNotifier
* Move metrics to WmUserMetricsAction
* Add RequestShutdown() to SystemTrayDelegate to avoid dependency on
LockStateController

BUG=619636
TEST=existing ash_unittests
==========

to

==========
mash: Migrate tray date view to //ash/common types

This eliminates ash::Shell dependencies.

* Move clock observers to WmSystemTrayNotifier
* Move metrics to WmUserMetricsAction
* Add RequestShutdown() to SystemTrayDelegate to avoid dependency on
LockStateController

BUG=619636
TEST=existing ash_unittests

Committed: https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912
Cr-Commit-Position: refs/heads/master@{#399747}
==========

[commit-bot: I haz the power, 2016-06-14 18:10:57]

Patchset 4 (id:??) landed as
https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912
Cr-Commit-Position: refs/heads/master@{#399747}