Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 2066173002: Fix WebViewTest.CloseOnLoadcommit flakiness. (Closed)

Created:
4 years, 6 months ago by lazyboy
Modified:
4 years, 6 months ago
Reviewers:
wjmaclean
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix WebViewTest.CloseOnLoadcommit flakiness. The test used to synchronously issue chrome.test.sendMessage from chrome.app.window.create's creation callback. Since the app window also loads a frame, this exposes a race, described in http://crbug.com/620194. Let the sendMessage happen in a setTimeout so the race is worked around. BUG=619148, 291278 Committed: https://crrev.com/a76393f3af2d8620d4104fc2a38e41636e11b5c4 Cr-Commit-Position: refs/heads/master@{#401683}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 1 chunk +1 line, -8 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/close_on_loadcommit/test.js View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
lazyboy
4 years, 6 months ago (2016-06-15 03:13:21 UTC) #3
lazyboy
@James, friendly ping.
4 years, 6 months ago (2016-06-23 17:25:38 UTC) #4
wjmaclean
On 2016/06/23 17:25:38, lazyboy wrote: > @James, friendly ping. Sorry, I missed this one! ...
4 years, 6 months ago (2016-06-23 17:48:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066173002/1
4 years, 6 months ago (2016-06-23 18:04:15 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 19:34:02 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 19:36:59 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a76393f3af2d8620d4104fc2a38e41636e11b5c4
Cr-Commit-Position: refs/heads/master@{#401683}

Powered by Google App Engine
This is Rietveld 408576698