Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3623)

Unified Diff: chrome/browser/apps/guest_view/web_view_browsertest.cc

Issue 2066173002: Fix WebViewTest.CloseOnLoadcommit flakiness. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/extensions/platform_apps/web_view/close_on_loadcommit/test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/apps/guest_view/web_view_browsertest.cc
diff --git a/chrome/browser/apps/guest_view/web_view_browsertest.cc b/chrome/browser/apps/guest_view/web_view_browsertest.cc
index 47755747eb88ca307d76dcf0f116daf8f7736c4a..1d00e502c031ed10e6c73f881fbfe51c64aeed6c 100644
--- a/chrome/browser/apps/guest_view/web_view_browsertest.cc
+++ b/chrome/browser/apps/guest_view/web_view_browsertest.cc
@@ -1733,14 +1733,7 @@ IN_PROC_BROWSER_TEST_P(WebViewTest, IndexedDBIsolation) {
// This test ensures that closing app window on 'loadcommit' does not crash.
// The test launches an app with guest and closes the window on loadcommit. It
// then launches the app window again. The process is repeated 3 times.
-// https://crbug.com/291278
-// https://crbug.com/619148
-#if defined(OS_WIN) || defined(MAC_OS_X_VERSION_10_9) || defined(OS_LINUX)
-#define MAYBE_CloseOnLoadcommit DISABLED_CloseOnLoadcommit
-#else
-#define MAYBE_CloseOnLoadcommit CloseOnLoadcommit
-#endif
-IN_PROC_BROWSER_TEST_P(WebViewTest, MAYBE_CloseOnLoadcommit) {
+IN_PROC_BROWSER_TEST_P(WebViewTest, CloseOnLoadcommit) {
LoadAndLaunchPlatformApp("web_view/close_on_loadcommit",
"done-close-on-loadcommit");
}
« no previous file with comments | « no previous file | chrome/test/data/extensions/platform_apps/web_view/close_on_loadcommit/test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698