Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: chrome/test/data/extensions/platform_apps/web_view/close_on_loadcommit/test.js

Issue 2066173002: Fix WebViewTest.CloseOnLoadcommit flakiness. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/apps/guest_view/web_view_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/platform_apps/web_view/close_on_loadcommit/test.js
diff --git a/chrome/test/data/extensions/platform_apps/web_view/close_on_loadcommit/test.js b/chrome/test/data/extensions/platform_apps/web_view/close_on_loadcommit/test.js
index 20ee24e3587909295c1e7f637ddccb203b05812c..5a0b304436ebca41b4d0c37980c8988e2cd11f71 100644
--- a/chrome/test/data/extensions/platform_apps/web_view/close_on_loadcommit/test.js
+++ b/chrome/test/data/extensions/platform_apps/web_view/close_on_loadcommit/test.js
@@ -11,7 +11,11 @@ var launchWindow = function() {
win.close();
launchWindow();
} else {
- chrome.test.sendMessage('done-close-on-loadcommit');
+ // Due to https://crbug.com/620194, we cannot sendMessage() synchronously
+ // from this callback. Let |win.onload| run before sendMessage is run.
+ setTimeout(function() {
+ chrome.test.sendMessage('done-close-on-loadcommit');
+ }, 0);
}
});
};
« no previous file with comments | « chrome/browser/apps/guest_view/web_view_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698