content/common/android/gin_java_bridge_value.h - Issue 2065793002: Return a unique_ptr from BinaryValue::CreateWithCopiedBuffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/android/gin_java_bridge_value.h

Issue 2065793002: Return a unique_ptr from BinaryValue::CreateWithCopiedBuffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Android and CrOS Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/pepper/pepper_socket_utils.cc ('K') | « content/child/v8_value_converter_impl.cc ('k') | content/common/android/gin_java_bridge_value.cc » ('j') | extensions/browser/api/web_request/upload_data_presenter_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/android/gin_java_bridge_value.h

diff --git a/content/common/android/gin_java_bridge_value.h b/content/common/android/gin_java_bridge_value.h

index b5090c3ea17948c899e9bbb6e6774d3e86918c7f..1cd92d8b76734c9f6a063b23239851e73df0d660 100644

--- a/content/common/android/gin_java_bridge_value.h

+++ b/content/common/android/gin_java_bridge_value.h

@@ -58,7 +58,7 @@ class GinJavaBridgeValue {

private:

explicit GinJavaBridgeValue(Type type);

explicit GinJavaBridgeValue(const base::BinaryValue* value);

- base::BinaryValue* SerializeToBinaryValue();

+ std::unique_ptr<base::BinaryValue> SerializeToBinaryValue();

base::Pickle pickle_;