Issue 2065463002: Always send queued retransmission packets, because of write blocked socket, once the socket gets un…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2065463002: Always send queued retransmission packets, because of write blocked socket, once the socket gets un… (Closed)

Created:
4 years, 6 months ago by jokulik

Modified:
4 years, 6 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, Fan Yang

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Always send queued retransmission packets, because of write blocked socket, once the socket gets unblocked. Protected by gfe2_reloadable_flag_quic_always_write_queued_retransmissions. Merge internal change: 124273380 R=rch@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : Changed test to use ValueRestore for flag flip. #

Patch Set 3 : Rebase. #

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -5 lines)			Patch
M	net/quic/quic_connection.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	net/quic/quic_connection_test.cc	View	1	2 chunks	+44 lines, -0 lines	0 comments	Download
M	net/quic/quic_flags.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/quic_flags.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	net/quic/quic_sent_packet_manager.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	net/quic/quic_unacked_packet_map.cc	View		1 chunk	+12 lines, -4 lines	0 comments	Download

Dependent Patchsets:

Issue 2064543002 Patch 20001

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages