Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: net/quic/quic_unacked_packet_map.cc

Issue 2065463002: Always send queued retransmission packets, because of write blocked socket, once the socket gets un… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_sent_packet_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_unacked_packet_map.cc
diff --git a/net/quic/quic_unacked_packet_map.cc b/net/quic/quic_unacked_packet_map.cc
index 90cdc3eba63c9a36a4dc6b10416dc65424739e91..d233ad2aa94cfb1582cc4f817f0f15f93537c32d 100644
--- a/net/quic/quic_unacked_packet_map.cc
+++ b/net/quic/quic_unacked_packet_map.cc
@@ -90,10 +90,18 @@ void QuicUnackedPacketMap::TransferRetransmissionInfo(
QuicPacketNumber new_packet_number,
TransmissionType transmission_type,
TransmissionInfo* info) {
- if (old_packet_number < least_unacked_ ||
- old_packet_number > largest_sent_packet_) {
- QUIC_BUG << "Old TransmissionInfo no longer exists for:"
- << old_packet_number << " least_unacked:" << least_unacked_
+ if (old_packet_number < least_unacked_) {
+ if (!FLAGS_quic_always_write_queued_retransmissions) {
+ QUIC_BUG << "Old TransmissionInfo no longer exists for:"
+ << old_packet_number << " least_unacked:" << least_unacked_;
+ }
+ // This can happen when a retransmission packet is queued because of write
+ // blocked socket, and the original packet gets acked before the
+ // retransmission gets sent.
+ return;
+ }
+ if (old_packet_number > largest_sent_packet_) {
+ QUIC_BUG << "Old TransmissionInfo never existed for :" << old_packet_number
<< " largest_sent:" << largest_sent_packet_;
return;
}
« no previous file with comments | « net/quic/quic_sent_packet_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698