net/quic/quic_sent_packet_manager.cc - Issue 2065463002: Always send queued retransmission packets, because of write blocked socket, once the socket gets un…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_sent_packet_manager.cc

Issue 2065463002: Always send queued retransmission packets, because of write blocked socket, once the socket gets un… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_sent_packet_manager.cc

diff --git a/net/quic/quic_sent_packet_manager.cc b/net/quic/quic_sent_packet_manager.cc

index 46a5029bf4b0eb82d64738fd1f0c9ca3c9adb166..d3c48a19cf2f0a73c43e00b79a2541ca6e243709 100644

--- a/net/quic/quic_sent_packet_manager.cc

+++ b/net/quic/quic_sent_packet_manager.cc

@@ -565,7 +565,8 @@ bool QuicSentPacketManager::OnPacketSent(

<< "Cannot send empty packets.";

if (delegate_ == nullptr && original_packet_number != 0) {

- if (!pending_retransmissions_.erase(original_packet_number)) {

+ if (!pending_retransmissions_.erase(original_packet_number) &&

+ !FLAGS_quic_always_write_queued_retransmissions) {

QUIC_BUG << "Expected packet number to be in "

<< "pending_retransmissions_. packet_number: "

<< original_packet_number;

« no previous file with comments | « net/quic/quic_flags.cc ('k') | net/quic/quic_unacked_packet_map.cc » ('j') | no next file with comments »