Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2065373003: [ic] LoadICState cleanup. (Closed)

Created:
4 years, 6 months ago by Igor Sheludko
Modified:
4 years, 6 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@cleanup-load-global-ic
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] LoadICState cleanup. LoadICState was used to hold the TypeofMode flag which is relevant only for LoadGlobalIC. This CL removes usage of this state from LoadIC and KeyedLoadIC and renames the state class to LoadGlobalICState. BUG=chromium:576312 LOG=Y Committed: https://crrev.com/5fcd3eb8a35a73aa3fe9d0090b38dc7818c7f437 Cr-Commit-Position: refs/heads/master@{#37033}

Patch Set 1 #

Patch Set 2 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -116 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/code-factory.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M src/code-stubs.h View 6 chunks +14 lines, -67 lines 0 comments Download
M src/disassembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/handler-compiler.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/ic/ic.h View 3 chunks +4 lines, -7 lines 0 comments Download
M src/ic/ic.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M src/ic/ic-compiler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ic/ic-state.h View 3 chunks +5 lines, -5 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065373003/20001
4 years, 6 months ago (2016-06-16 08:47:03 UTC) #2
Igor Sheludko
PTAL
4 years, 6 months ago (2016-06-16 09:16:17 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-16 09:19:05 UTC) #6
mvstanton
Nice cleanup! LGTM.
4 years, 6 months ago (2016-06-16 09:47:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065373003/20001
4 years, 6 months ago (2016-06-16 10:55:26 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-16 11:20:13 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 11:22:22 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5fcd3eb8a35a73aa3fe9d0090b38dc7818c7f437
Cr-Commit-Position: refs/heads/master@{#37033}

Powered by Google App Engine
This is Rietveld 408576698