Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Unified Diff: src/ic/ic-state.h

Issue 2065373003: [ic] LoadICState cleanup. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@cleanup-load-global-ic
Patch Set: Rebasing Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ic/ic-compiler.cc ('k') | src/mips/code-stubs-mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic/ic-state.h
diff --git a/src/ic/ic-state.h b/src/ic/ic-state.h
index 9b99cbbfe8abe29d75b2052f7b2cb132689f58be..b12b17d3e20b2eb3a04cecbc27189ceed5a1ffb3 100644
--- a/src/ic/ic-state.h
+++ b/src/ic/ic-state.h
@@ -199,8 +199,7 @@ class CompareICState {
Handle<Object> y);
};
-
-class LoadICState final BASE_EMBEDDED {
+class LoadGlobalICState final BASE_EMBEDDED {
private:
class TypeofModeBits : public BitField<TypeofMode, 0, 1> {};
STATIC_ASSERT(static_cast<int>(INSIDE_TYPEOF) == 0);
@@ -209,9 +208,10 @@ class LoadICState final BASE_EMBEDDED {
public:
static const uint32_t kNextBitFieldOffset = TypeofModeBits::kNext;
- explicit LoadICState(ExtraICState extra_ic_state) : state_(extra_ic_state) {}
+ explicit LoadGlobalICState(ExtraICState extra_ic_state)
+ : state_(extra_ic_state) {}
- explicit LoadICState(TypeofMode typeof_mode)
+ explicit LoadGlobalICState(TypeofMode typeof_mode)
: state_(TypeofModeBits::encode(typeof_mode)) {}
ExtraICState GetExtraICState() const { return state_; }
@@ -219,7 +219,7 @@ class LoadICState final BASE_EMBEDDED {
TypeofMode typeof_mode() const { return TypeofModeBits::decode(state_); }
static TypeofMode GetTypeofMode(ExtraICState state) {
- return LoadICState(state).typeof_mode();
+ return LoadGlobalICState(state).typeof_mode();
}
};
« no previous file with comments | « src/ic/ic-compiler.cc ('k') | src/mips/code-stubs-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698