Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2062343002: [ic] Remove --new-load-global-ic switch. (Closed)

Created:
4 years, 6 months ago by Igor Sheludko
Modified:
4 years, 6 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@enable-load-global-ic
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Remove --new-load-global-ic switch. BUG=chromium:576312 LOG=Y Committed: https://crrev.com/d6b3b7e61ccf74f9018ca50ced7831c195675658 Cr-Commit-Position: refs/heads/master@{#37030}

Patch Set 1 #

Patch Set 2 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -75 lines) Patch
M src/code-stubs.h View 2 chunks +18 lines, -18 lines 0 comments Download
M src/code-stubs.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M src/flag-definitions.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/ic.cc View 4 chunks +4 lines, -13 lines 0 comments Download
M src/type-feedback-vector.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/type-feedback-vector.cc View 3 chunks +5 lines, -32 lines 0 comments Download

Dependent Patchsets:

Issue 2065373003 Patch 20001

Messages

Total messages: 17 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062343002/1
4 years, 6 months ago (2016-06-15 09:16:07 UTC) #2
Igor Sheludko
PTAL
4 years, 6 months ago (2016-06-15 09:17:59 UTC) #5
Igor Sheludko
I'm going to land it if the new LoadGlobalIC machinery will stick in the tree.
4 years, 6 months ago (2016-06-15 09:18:39 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062343002/40001
4 years, 6 months ago (2016-06-16 08:46:12 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-16 09:14:49 UTC) #10
Igor Sheludko
I think LoadGlobalIC looks good and we can move forward.
4 years, 6 months ago (2016-06-16 09:15:33 UTC) #11
mvstanton
Fair enough! LGTM.
4 years, 6 months ago (2016-06-16 09:44:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062343002/40001
4 years, 6 months ago (2016-06-16 09:45:35 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-06-16 09:47:59 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 09:48:31 UTC) #17
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d6b3b7e61ccf74f9018ca50ced7831c195675658
Cr-Commit-Position: refs/heads/master@{#37030}

Powered by Google App Engine
This is Rietveld 408576698