Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2065243002: Placing SRT Prompt on Feedback form behind Finch feature. (Closed)

Created:
4 years, 6 months ago by tmartino
Modified:
4 years, 5 months ago
Reviewers:
afakhry, MAD
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Placing SRT Prompt on Feedback form behind Finch feature. BUG=598702 Committed: https://crrev.com/3e84f9c83383458a944c122ac3cb628d844d750d Cr-Commit-Position: refs/heads/master@{#402311}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Moving to anonymous namespace #

Total comments: 2

Patch Set 3 : Formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M chrome/browser/extensions/api/feedback_private/feedback_private_api.cc View 1 2 3 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 27 (11 generated)
MAD
lgtm
4 years, 6 months ago (2016-06-21 19:32:20 UTC) #2
tmartino
Hi Ahmed, Under advisement from the SRT team, we've decided to gate the feedback page's ...
4 years, 6 months ago (2016-06-21 19:42:26 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065243002/1
4 years, 6 months ago (2016-06-21 19:48:30 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-21 21:06:54 UTC) #8
afakhry
https://codereview.chromium.org/2065243002/diff/1/chrome/browser/extensions/api/feedback_private/feedback_private_api.h File chrome/browser/extensions/api/feedback_private/feedback_private_api.h (right): https://codereview.chromium.org/2065243002/diff/1/chrome/browser/extensions/api/feedback_private/feedback_private_api.h#newcode18 chrome/browser/extensions/api/feedback_private/feedback_private_api.h:18: extern const base::Feature kSrtPromptOnFeedbackForm; If it's only needed in ...
4 years, 6 months ago (2016-06-22 12:58:42 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065243002/20001
4 years, 6 months ago (2016-06-23 20:04:35 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-23 21:00:51 UTC) #13
tmartino
Done.
4 years, 5 months ago (2016-06-27 19:35:58 UTC) #14
afakhry
https://codereview.chromium.org/2065243002/diff/20001/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc File chrome/browser/extensions/api/feedback_private/feedback_private_api.cc (right): https://codereview.chromium.org/2065243002/diff/20001/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc#newcode37 chrome/browser/extensions/api/feedback_private/feedback_private_api.cc:37: #include "chrome/common/extensions/api/feedback_private.h" Nit: Please remove this include. This file ...
4 years, 5 months ago (2016-06-27 19:59:54 UTC) #15
tmartino
On 2016/06/27 at 19:59:54, afakhry wrote: > https://codereview.chromium.org/2065243002/diff/20001/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc > File chrome/browser/extensions/api/feedback_private/feedback_private_api.cc (right): > > https://codereview.chromium.org/2065243002/diff/20001/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc#newcode37 ...
4 years, 5 months ago (2016-06-27 20:38:21 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2065243002/40001
4 years, 5 months ago (2016-06-27 20:39:11 UTC) #18
afakhry
lgtm
4 years, 5 months ago (2016-06-27 20:49:35 UTC) #19
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-27 21:57:31 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2065243002/40001
4 years, 5 months ago (2016-06-27 21:59:09 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-27 22:05:32 UTC) #25
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 22:08:33 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3e84f9c83383458a944c122ac3cb628d844d750d
Cr-Commit-Position: refs/heads/master@{#402311}

Powered by Google App Engine
This is Rietveld 408576698