|
|
Created:
4 years, 6 months ago by tmartino Modified:
4 years, 5 months ago CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPlacing SRT Prompt on Feedback form behind Finch feature.
BUG=598702
Committed: https://crrev.com/3e84f9c83383458a944c122ac3cb628d844d750d
Cr-Commit-Position: refs/heads/master@{#402311}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Moving to anonymous namespace #
Total comments: 2
Patch Set 3 : Formatting #Messages
Total messages: 27 (11 generated)
mad@chromium.org changed reviewers: + mad@chromium.org
lgtm
tmartino@chromium.org changed reviewers: + afakhry@chromium.org
Hi Ahmed, Under advisement from the SRT team, we've decided to gate the feedback page's inline prompt behind a Finch feature, rather than rolling out to all stable. Adding you as OWNERS reviewer. Thanks!
The CQ bit was checked by tmartino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065243002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2065243002/diff/1/chrome/browser/extensions/a... File chrome/browser/extensions/api/feedback_private/feedback_private_api.h (right): https://codereview.chromium.org/2065243002/diff/1/chrome/browser/extensions/a... chrome/browser/extensions/api/feedback_private/feedback_private_api.h:18: extern const base::Feature kSrtPromptOnFeedbackForm; If it's only needed in feedback_private_api.cc, is there a reason why it's defined as extern here? Can you define it as constexpr in the anonymous namespace in the .cc file?
The CQ bit was checked by tmartino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065243002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Done.
https://codereview.chromium.org/2065243002/diff/20001/chrome/browser/extensio... File chrome/browser/extensions/api/feedback_private/feedback_private_api.cc (right): https://codereview.chromium.org/2065243002/diff/20001/chrome/browser/extensio... chrome/browser/extensions/api/feedback_private/feedback_private_api.cc:37: #include "chrome/common/extensions/api/feedback_private.h" Nit: Please remove this include. This file is already included in the .h file. https://codereview.chromium.org/2065243002/diff/20001/chrome/browser/extensio... chrome/browser/extensions/api/feedback_private/feedback_private_api.cc:98: Nit: Remove this line.
On 2016/06/27 at 19:59:54, afakhry wrote: > https://codereview.chromium.org/2065243002/diff/20001/chrome/browser/extensio... > File chrome/browser/extensions/api/feedback_private/feedback_private_api.cc (right): > > https://codereview.chromium.org/2065243002/diff/20001/chrome/browser/extensio... > chrome/browser/extensions/api/feedback_private/feedback_private_api.cc:37: #include "chrome/common/extensions/api/feedback_private.h" > Nit: Please remove this include. This file is already included in the .h file. > > https://codereview.chromium.org/2065243002/diff/20001/chrome/browser/extensio... > chrome/browser/extensions/api/feedback_private/feedback_private_api.cc:98: > Nit: Remove this line. Done.
The CQ bit was checked by tmartino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tmartino@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mad@chromium.org Link to the patchset: https://codereview.chromium.org/2065243002/#ps40001 (title: "Formatting")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Placing SRT Prompt on Feedback form behind Finch feature. BUG=598702 ========== to ========== Placing SRT Prompt on Feedback form behind Finch feature. BUG=598702 Committed: https://crrev.com/3e84f9c83383458a944c122ac3cb628d844d750d Cr-Commit-Position: refs/heads/master@{#402311} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/3e84f9c83383458a944c122ac3cb628d844d750d Cr-Commit-Position: refs/heads/master@{#402311} |