Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

Issue 2065243002: Placing SRT Prompt on Feedback form behind Finch feature. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Formatting Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
diff --git a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
index 6e570edb81d076bbc183e29356e4369d0cca2a41..164e2a41278ff7ac0beb231b3ee05603485ea282 100644
--- a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
+++ b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
@@ -32,6 +32,7 @@
#include "url/url_util.h"
#if defined(OS_WIN)
+#include "base/feature_list.h"
#include "chrome/browser/safe_browsing/srt_fetcher_win.h"
#endif
@@ -50,6 +51,13 @@ std::string StripFakepath(const std::string& path) {
return path;
}
+#if defined(OS_WIN)
+// Allows enabling/disabling SRT Prompt as a Variations feature.
+constexpr base::Feature kSrtPromptOnFeedbackForm {
+ "SrtPromptOnFeedbackForm", base::FEATURE_DISABLED_BY_DEFAULT
+};
+#endif
+
} // namespace
namespace extensions {
@@ -89,14 +97,14 @@ void FeedbackPrivateAPI::RequestFeedback(
#if defined(OS_WIN)
// Show prompt for Software Removal Tool if the Reporter component has found
// unwanted software, and the user has never run the cleaner before.
- if (safe_browsing::ReporterFoundUws() &&
+ if (base::FeatureList::IsEnabled(kSrtPromptOnFeedbackForm) &&
+ safe_browsing::ReporterFoundUws() &&
!safe_browsing::UserHasRunCleaner()) {
RequestFeedbackForFlow(description_template, category_tag, page_url,
FeedbackFlow::FEEDBACK_FLOW_SHOWSRTPROMPT);
return;
}
#endif
-
RequestFeedbackForFlow(description_template, category_tag, page_url,
FeedbackFlow::FEEDBACK_FLOW_REGULAR);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698