Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2064673002: [cleanup] Drop unused scratch register from {load,store}_calling_convention (Closed)

Created:
4 years, 6 months ago by Jakob Kummerow
Modified:
4 years, 6 months ago
Reviewers:
Camillo Bruni
CC:
v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] Drop unused scratch register from {load,store}_calling_convention Committed: https://crrev.com/bd451d421b431bba6679c77e044f04719822942f Cr-Commit-Position: refs/heads/master@{#36958}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -39 lines) Patch
M src/ic/access-compiler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ic/arm/access-compiler-arm.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/ic/arm64/access-compiler-arm64.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/ic/handler-compiler.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/ic/ia32/access-compiler-ia32.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/ic/mips/access-compiler-mips.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/ic/mips64/access-compiler-mips64.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/ic/ppc/access-compiler-ppc.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/ic/s390/access-compiler-s390.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/ic/x64/access-compiler-x64.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/ic/x87/access-compiler-x87.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jakob Kummerow
As discussed, PTAL.
4 years, 6 months ago (2016-06-13 12:10:22 UTC) #2
Camillo Bruni
LGTM nice! :)
4 years, 6 months ago (2016-06-14 09:46:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064673002/1
4 years, 6 months ago (2016-06-14 09:47:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 10:17:52 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 10:18:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd451d421b431bba6679c77e044f04719822942f
Cr-Commit-Position: refs/heads/master@{#36958}

Powered by Google App Engine
This is Rietveld 408576698