Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Side by Side Diff: src/ic/access-compiler.h

Issue 2064673002: [cleanup] Drop unused scratch register from {load,store}_calling_convention (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/ic/arm/access-compiler-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_IC_ACCESS_COMPILER_H_ 5 #ifndef V8_IC_ACCESS_COMPILER_H_
6 #define V8_IC_ACCESS_COMPILER_H_ 6 #define V8_IC_ACCESS_COMPILER_H_
7 7
8 #include "src/code-stubs.h" 8 #include "src/code-stubs.h"
9 #include "src/macro-assembler.h" 9 #include "src/macro-assembler.h"
10 #include "src/objects.h" 10 #include "src/objects.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 Isolate* isolate() const { return isolate_; } 51 Isolate* isolate() const { return isolate_; }
52 Heap* heap() const { return isolate()->heap(); } 52 Heap* heap() const { return isolate()->heap(); }
53 Factory* factory() const { return isolate()->factory(); } 53 Factory* factory() const { return isolate()->factory(); }
54 54
55 Register receiver() const { return registers_[0]; } 55 Register receiver() const { return registers_[0]; }
56 Register name() const { return registers_[1]; } 56 Register name() const { return registers_[1]; }
57 Register slot() const; 57 Register slot() const;
58 Register vector() const; 58 Register vector() const;
59 Register scratch1() const { return registers_[2]; } 59 Register scratch1() const { return registers_[2]; }
60 Register scratch2() const { return registers_[3]; } 60 Register scratch2() const { return registers_[3]; }
61 Register scratch3() const { return registers_[4]; }
62 61
63 static Register* GetCallingConvention(Code::Kind); 62 static Register* GetCallingConvention(Code::Kind);
64 static Register* load_calling_convention(); 63 static Register* load_calling_convention();
65 static Register* store_calling_convention(); 64 static Register* store_calling_convention();
66 static Register* keyed_store_calling_convention(); 65 static Register* keyed_store_calling_convention();
67 66
68 Register* registers_; 67 Register* registers_;
69 68
70 static void GenerateTailCall(MacroAssembler* masm, Handle<Code> code); 69 static void GenerateTailCall(MacroAssembler* masm, Handle<Code> code);
71 70
72 Handle<Code> GetCodeWithFlags(Code::Flags flags, const char* name); 71 Handle<Code> GetCodeWithFlags(Code::Flags flags, const char* name);
73 Handle<Code> GetCodeWithFlags(Code::Flags flags, Handle<Name> name); 72 Handle<Code> GetCodeWithFlags(Code::Flags flags, Handle<Name> name);
74 73
75 private: 74 private:
76 Code::Kind kind_; 75 Code::Kind kind_;
77 CacheHolderFlag cache_holder_; 76 CacheHolderFlag cache_holder_;
78 77
79 Isolate* isolate_; 78 Isolate* isolate_;
80 MacroAssembler masm_; 79 MacroAssembler masm_;
81 // Ensure that MacroAssembler has a reasonable size. 80 // Ensure that MacroAssembler has a reasonable size.
82 STATIC_ASSERT(sizeof(MacroAssembler) < 128 * kPointerSize); 81 STATIC_ASSERT(sizeof(MacroAssembler) < 128 * kPointerSize);
83 }; 82 };
84 } // namespace internal 83 } // namespace internal
85 } // namespace v8 84 } // namespace v8
86 85
87 #endif // V8_IC_ACCESS_COMPILER_H_ 86 #endif // V8_IC_ACCESS_COMPILER_H_
OLDNEW
« no previous file with comments | « no previous file | src/ic/arm/access-compiler-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698