chrome/renderer/BUILD.gn - Issue 2064463002: Mojo interface/service for Leak Detector on remote process

Unified Diff: chrome/renderer/BUILD.gn

Issue 2064463002: Mojo interface/service for Leak Detector on remote process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comment about unretained binding; Decompose protobufs into mojo structs Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/leak_detector/leak_detector_remote_controller.cc ('K') | « chrome/chrome_renderer.gypi ('k') | chrome/renderer/DEPS » ('j') | chrome/renderer/leak_detector_remote_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/BUILD.gn

diff --git a/chrome/renderer/BUILD.gn b/chrome/renderer/BUILD.gn

index 3760d3094befadeab682fdadf7bf5de52c842c04..a147d93ebc1f233cdaf8891ec6f0a93a6be4676f 100644

--- a/chrome/renderer/BUILD.gn

+++ b/chrome/renderer/BUILD.gn

@@ -182,6 +182,16 @@ static_library("renderer") {

"spellchecker/hunspell_engine.h",

]

}

+ if (is_chromeos) {

+ sources += rebase_path(gypi_values.chrome_renderer_leak_detector_sources,

+ ".",

+ "..")

+ deps += [

+ "//components/metrics:interfaces",

+ "//components/metrics:leak_detector",

+ ]

+ }

Ilya Sherman 2016/06/17 22:18:20 IMO it would be nice to immediately start out with

Simon Que 2016/06/18 04:17:53 I can do that, but is it necessary for just two fi

Ilya Sherman 2016/06/28 21:33:10 Necessary? No. But it does have some nice advant

Simon Que 2016/06/29 02:30:46 Done in Patch Set 9.

}

# In GYP this is part of test_support_common.