Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: chrome/browser/metrics/leak_detector/leak_detector_remote_controller.cc

Issue 2064463002: Mojo interface/service for Leak Detector on remote process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comment about unretained binding; Decompose protobufs into mojo structs Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/leak_detector/leak_detector_remote_controller.cc
diff --git a/chrome/browser/metrics/leak_detector/leak_detector_remote_controller.cc b/chrome/browser/metrics/leak_detector/leak_detector_remote_controller.cc
new file mode 100644
index 0000000000000000000000000000000000000000..d09c56c6158655286973f73014b26e65279ace1a
--- /dev/null
+++ b/chrome/browser/metrics/leak_detector/leak_detector_remote_controller.cc
@@ -0,0 +1,84 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/metrics/leak_detector/leak_detector_remote_controller.h"
+
+#include "content/public/browser/browser_thread.h"
+
+namespace metrics {
+
+namespace {
+
+// All instances of LeakDetectorRemoteController will need to reference a single
+// LocalController instance, referenced by this pointer. All remote LeakDetector
+// clients will get their params from and send leak reports to this instance.
+LeakDetectorRemoteController::LocalController* g_local_controller = nullptr;
+
+} // namespace
+
+LeakDetectorRemoteController::~LeakDetectorRemoteController() {}
+
+// static
+void LeakDetectorRemoteController::Create(LeakDetectorRemoteRequest request) {
+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+ new LeakDetectorRemoteController(std::move(request));
Ilya Sherman 2016/06/17 22:18:20 I really wish that Mojo didn't use a pattern that
+}
+
+void LeakDetectorRemoteController::GetParams(
+ const LeakDetectorRemote::GetParamsCallback& callback) {
+ // If no controller exists, send an empty param protobuf. The remote caller
+ // should not initialize anything if the params are empty.
+ MemoryLeakReportProto_Params params;
+ if (g_local_controller) {
+ params = g_local_controller->GetParams();
+ }
+
+ mojo::StructPtr<LeakDetectorParams> mojo_params = LeakDetectorParams::New();
+ mojo_params->sampling_rate = params.sampling_rate();
+ mojo_params->max_stack_depth = params.max_stack_depth();
+ mojo_params->analysis_interval_bytes = params.analysis_interval_bytes();
+ mojo_params->size_suspicion_threshold = params.size_suspicion_threshold();
+ mojo_params->call_stack_suspicion_threshold =
+ params.call_stack_suspicion_threshold();
+
+ callback.Run(std::move(mojo_params));
+}
+
+void LeakDetectorRemoteController::SendLeakReports(
+ mojo::Array<MemoryLeakReportPtr> reports) {
+ std::vector<MemoryLeakReportProto> report_protos;
+ report_protos.reserve(reports.size());
+
+ for (const MemoryLeakReportPtr& report : reports) {
+ report_protos.push_back(MemoryLeakReportProto());
+ auto proto = report_protos.back();
+
+ proto.set_size_bytes(report->size_bytes);
+ for (auto call_stack_addr : report->call_stack)
+ proto.add_call_stack(call_stack_addr);
+
+ for (const auto& history_entry : report->alloc_breakdown_history) {
+ auto proto_entry = proto.add_alloc_breakdown_history();
+ for (auto count : history_entry->counts_by_size) {
+ proto_entry->add_counts_by_size(count);
+ }
+ proto_entry->set_count_for_call_stack(
+ history_entry->count_for_call_stack);
+ }
+ }
+ DCHECK(g_local_controller);
+ g_local_controller->SendLeakReports(report_protos);
+}
+
+LeakDetectorRemoteController::LeakDetectorRemoteController(
+ LeakDetectorRemoteRequest request)
+ : binding_(this, std::move(request)) {}
+
+// static
+void LeakDetectorRemoteController::SetLocalControllerInstance(
+ LocalController* controller) {
+ g_local_controller = controller;
+}
+
+} // namespace metrics

Powered by Google App Engine
This is Rietveld 408576698