Mojo interface/service for Leak Detector on remote process

chrome/browser/metrics/leak_detector/leak_detector_controller.h

Index: chrome/browser/metrics/leak_detector/leak_detector_controller.h
diff --git a/chrome/browser/metrics/leak_detector/leak_detector_controller.h b/chrome/browser/metrics/leak_detector/leak_detector_controller.h
index 7dabdfb8259e222970705533672bfc965d5f9e96..f237a198773595fcd79e2e7978c65f9131508609 100644
--- a/chrome/browser/metrics/leak_detector/leak_detector_controller.h
+++ b/chrome/browser/metrics/leak_detector/leak_detector_controller.h
@@ -9,6 +9,7 @@
 
 #include "base/macros.h"
 #include "base/threading/thread_checker.h"
+#include "chrome/browser/metrics/leak_detector/leak_detector_remote_controller.h"
 #include "components/metrics/leak_detector/leak_detector.h"
 #include "components/metrics/proto/memory_leak_report.pb.h"
 
@@ -16,7 +17,9 @@ namespace metrics {
 
 // This class initializes the LeakDetector on the browser process and registers
 // itself to be notified of leak reports.
-class LeakDetectorController : public LeakDetector::Observer {
+class LeakDetectorController
+    : public LeakDetector::Observer,
+      public LeakDetectorRemoteController::LocalController {
  public:
   LeakDetectorController();
   ~LeakDetectorController() override;
@@ -29,6 +32,12 @@ class LeakDetectorController : public LeakDetector::Observer {
   // LeakDetector::Observer:
   void OnLeaksFound(const std::vector<MemoryLeakReportProto>& reports) override;
 
+  // LeakDetectorRemoteController::LocalController
+  MemoryLeakReportProto::Params GetParams() override;

[Ilya Sherman, 2016/06/17 22:18:20]

nit: Should this method be const?

[Simon Que, 2016/06/18 04:17:53]

No, in the next CL this will be used to determine which remote processes should
have leak detector enabled vs disabled (= empty params). This class will then
need to track how many remote processes have leak detector enabled. This is a
mechanism to limit the number of processes that are running leak detector at any
given time.

[Ilya Sherman, 2016/06/28 21:33:10]

That's pretty surprising behavior for a method simply named "GetParams()".  I
would maybe recommending marking the method const for now, and updating it in
the next CL, including definitely more comments, and possibly a different name
altogether.

[Simon Que, 2016/06/29 02:30:46]

Done.

+  void SendLeakReports(
+      const std::vector<MemoryLeakReportProto>& reports) override;
+  void OnRemoteProcessShutdown() override;
+
  private:
   // All leak reports received through OnLeakFound() are stored in protobuf
   // format.