Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2064163002: Revert of [turbofan] Introduce a dedicated CheckBounds operator. (Closed)

Created:
4 years, 6 months ago by vogelheim
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Introduce a dedicated CheckBounds operator. (patchset #5 id:80001 of https://codereview.chromium.org/2035893004/ ) Reason for revert: Speculative revert since V8 roll is blocked. Buildbot: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/228171 Example log: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/228171/steps/browser_tests%20%28with%20patch%29%20on%20Ubuntu-12.04/logs/CreateNewFolder_FileManagerBrowserTest.Test_0 Failing assert: # # Fatal error in ../../v8/src/compiler/node.cc, line 63 # Node::New() Error: #202:DeoptimizeUnless[1] is nullptr # (I take it that's a rather generic assert in TF, hence the revert is somewhat sepculative.) Original issue's description: > [turbofan] Introduce a dedicated CheckBounds operator. > > This CheckBounds simplified operator is similar to the HBoundsCheck in > Crankshaft, and is hooked up to the new type feedback support in the > SimplifiedLowering. We use it to check the index bounds for keyed > property accesses. > > Note to perf sheriffs: This will tank quite a few benchmarks, as the > operator makes some redundant branch elimination ineffective for > certain patterns of keyed accesses. This does require more serious > redundancy elimination, which we will do in a separate CL. So ignore > any regressions from this CL, we know there will be a few. > > R=jarin@chromium.org > BUG=v8:4470, v8:5100 > > Committed: https://crrev.com/85e5567dae66a918500ae94c5568221137a0f5d4 > Cr-Commit-Position: refs/heads/master@{#36947} TBR=jarin@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4470, v8:5100 Committed: https://crrev.com/d20e8183b4317b9511390e36b296da3ee355d9d0 Cr-Commit-Position: refs/heads/master@{#36975}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -144 lines) Patch
M src/compiler/effect-control-linearizer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 3 chunks +15 lines, -44 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 4 chunks +28 lines, -20 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +0 lines, -6 lines 0 comments Download
D test/mjsunit/compiler/regress-5100.js View 1 chunk +0 lines, -51 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
vogelheim
Created Revert of [turbofan] Introduce a dedicated CheckBounds operator.
4 years, 6 months ago (2016-06-14 16:08:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064163002/1
4 years, 6 months ago (2016-06-14 16:08:12 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 16:08:25 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 16:09:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d20e8183b4317b9511390e36b296da3ee355d9d0
Cr-Commit-Position: refs/heads/master@{#36975}

Powered by Google App Engine
This is Rietveld 408576698