Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: src/compiler/verifier.cc

Issue 2064163002: Revert of [turbofan] Introduce a dedicated CheckBounds operator. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | test/mjsunit/compiler/regress-5100.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 910 matching lines...) Expand 10 before | Expand all | Expand 10 after
921 case IrOpcode::kTruncateTaggedToWord32: { 921 case IrOpcode::kTruncateTaggedToWord32: {
922 // Number /\ Tagged -> Signed32 /\ UntaggedInt32 922 // Number /\ Tagged -> Signed32 /\ UntaggedInt32
923 // TODO(neis): Activate once ChangeRepresentation works in typer. 923 // TODO(neis): Activate once ChangeRepresentation works in typer.
924 // Type* from = Type::Intersect(Type::Number(), Type::Tagged()); 924 // Type* from = Type::Intersect(Type::Number(), Type::Tagged());
925 // Type* to = Type::Intersect(Type::Number(), Type::UntaggedInt32()); 925 // Type* to = Type::Intersect(Type::Number(), Type::UntaggedInt32());
926 // CheckValueInputIs(node, 0, from)); 926 // CheckValueInputIs(node, 0, from));
927 // CheckUpperIs(node, to)); 927 // CheckUpperIs(node, to));
928 break; 928 break;
929 } 929 }
930 930
931 case IrOpcode::kCheckBounds:
932 CheckValueInputIs(node, 0, Type::Any());
933 CheckValueInputIs(node, 1, Type::Unsigned31());
934 CheckUpperIs(node, Type::Unsigned31());
935 break;
936
937 case IrOpcode::kCheckedUint32ToInt32: 931 case IrOpcode::kCheckedUint32ToInt32:
938 case IrOpcode::kCheckedFloat64ToInt32: 932 case IrOpcode::kCheckedFloat64ToInt32:
939 case IrOpcode::kCheckedTaggedToInt32: 933 case IrOpcode::kCheckedTaggedToInt32:
940 case IrOpcode::kCheckedTaggedToFloat64: 934 case IrOpcode::kCheckedTaggedToFloat64:
941 break; 935 break;
942 936
943 case IrOpcode::kLoadField: 937 case IrOpcode::kLoadField:
944 // Object -> fieldtype 938 // Object -> fieldtype
945 // TODO(rossberg): activate once machine ops are typed. 939 // TODO(rossberg): activate once machine ops are typed.
946 // CheckValueInputIs(node, 0, Type::Object()); 940 // CheckValueInputIs(node, 0, Type::Object());
(...skipping 494 matching lines...) Expand 10 before | Expand all | Expand 10 after
1441 replacement->op()->EffectOutputCount() > 0); 1435 replacement->op()->EffectOutputCount() > 0);
1442 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1436 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1443 replacement->opcode() == IrOpcode::kFrameState); 1437 replacement->opcode() == IrOpcode::kFrameState);
1444 } 1438 }
1445 1439
1446 #endif // DEBUG 1440 #endif // DEBUG
1447 1441
1448 } // namespace compiler 1442 } // namespace compiler
1449 } // namespace internal 1443 } // namespace internal
1450 } // namespace v8 1444 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/typer.cc ('k') | test/mjsunit/compiler/regress-5100.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698