[turbofan] Introduce a dedicated CheckBounds operator.

[turbofan] Introduce a dedicated CheckBounds operator.

This CheckBounds simplified operator is similar to the HBoundsCheck in
Crankshaft, and is hooked up to the new type feedback support in the
SimplifiedLowering. We use it to check the index bounds for keyed
property accesses.

Note to perf sheriffs: This will tank quite a few benchmarks, as the
operator makes some redundant branch elimination ineffective for
certain patterns of keyed accesses. This does require more serious
redundancy elimination, which we will do in a separate CL. So ignore
any regressions from this CL, we know there will be a few.

R=jarin@chromium.org
BUG=v8:4470, v8:5100
Committed: https://crrev.com/85e5567dae66a918500ae94c5568221137a0f5d4
Committed: https://crrev.com/2267ccb1bb173f563c08b7fb7e9cdf8c2bd5e332
Cr-Original-Commit-Position: refs/heads/master@{#36947}
Cr-Commit-Position: refs/heads/master@{#37003}

[Jarin, 2016-06-11 10:27:00]

On 2016/06/03 09:55:09, Benedikt Meurer wrote:

lgtm (once it is updated to work with the latest checkpointing mechanism).

[Benedikt Meurer, 2016-06-13 08:02:55]

Description was changed from

==========
[turbofan] Introduce a dedicated CheckBounds operator.

This CheckBounds simplified operator is similar to the HBoundsCheck in
Crankshaft, and is hooked up to the new type feedback support in the
SimplifiedLowering. We use it to check the index bounds for keyed
property accesses.

R=jarin@chromium.org
BUG=v8:4470
==========

to

==========
[turbofan] Introduce a dedicated CheckBounds operator.

This CheckBounds simplified operator is similar to the HBoundsCheck in
Crankshaft, and is hooked up to the new type feedback support in the
SimplifiedLowering. We use it to check the index bounds for keyed
property accesses.

R=jarin@chromium.org
BUG=v8:4470,v8:5100
==========

[Benedikt Meurer, 2016-06-13 15:28:06]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-13 15:28:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2035893004/40001

[commit-bot: I haz the power, 2016-06-13 15:57:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 15:57:56]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer, 2016-06-13 18:19:56]

Description was changed from

==========
[turbofan] Introduce a dedicated CheckBounds operator.

This CheckBounds simplified operator is similar to the HBoundsCheck in
Crankshaft, and is hooked up to the new type feedback support in the
SimplifiedLowering. We use it to check the index bounds for keyed
property accesses.

R=jarin@chromium.org
BUG=v8:4470,v8:5100
==========

to

==========
[turbofan] Introduce a dedicated CheckBounds operator.

This CheckBounds simplified operator is similar to the HBoundsCheck in
Crankshaft, and is hooked up to the new type feedback support in the
SimplifiedLowering. We use it to check the index bounds for keyed
property accesses.

Note to perf sheriffs: This will tank quite a few benchmarks, as the
operator makes some redundant branch elimination ineffective for
certain patterns of keyed accesses. This does require more serious
redundancy elimination, which we will do in a separate CL. So ignore
any regressions from this CL, we know there will be a few.

R=jarin@chromium.org
BUG=v8:4470,v8:5100
==========

[Benedikt Meurer, 2016-06-13 18:20:05]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-06-13 18:20:05]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2035893004/#ps60001
(title: "Fix invalid truncation of array indices.")

[commit-bot: I haz the power, 2016-06-13 18:20:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2035893004/60001

[commit-bot: I haz the power, 2016-06-13 18:40:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 18:40:04]

Try jobs failed on following builders:
  v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/7235)
  v8_linux64_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng_triggered...)

[Benedikt Meurer, 2016-06-14 03:51:11]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-06-14 03:51:11]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2035893004/#ps80001
(title: "Fix invalid conversion.")

[commit-bot: I haz the power, 2016-06-14 03:51:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2035893004/80001

[commit-bot: I haz the power, 2016-06-14 05:37:37]

Description was changed from

==========
[turbofan] Introduce a dedicated CheckBounds operator.

This CheckBounds simplified operator is similar to the HBoundsCheck in
Crankshaft, and is hooked up to the new type feedback support in the
SimplifiedLowering. We use it to check the index bounds for keyed
property accesses.

Note to perf sheriffs: This will tank quite a few benchmarks, as the
operator makes some redundant branch elimination ineffective for
certain patterns of keyed accesses. This does require more serious
redundancy elimination, which we will do in a separate CL. So ignore
any regressions from this CL, we know there will be a few.

R=jarin@chromium.org
BUG=v8:4470,v8:5100
==========

to

==========
[turbofan] Introduce a dedicated CheckBounds operator.

This CheckBounds simplified operator is similar to the HBoundsCheck in
Crankshaft, and is hooked up to the new type feedback support in the
SimplifiedLowering. We use it to check the index bounds for keyed
property accesses.

Note to perf sheriffs: This will tank quite a few benchmarks, as the
operator makes some redundant branch elimination ineffective for
certain patterns of keyed accesses. This does require more serious
redundancy elimination, which we will do in a separate CL. So ignore
any regressions from this CL, we know there will be a few.

R=jarin@chromium.org
BUG=v8:4470,v8:5100
==========

[commit-bot: I haz the power, 2016-06-14 05:37:38]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-14 06:12:19]

Description was changed from

==========
[turbofan] Introduce a dedicated CheckBounds operator.

This CheckBounds simplified operator is similar to the HBoundsCheck in
Crankshaft, and is hooked up to the new type feedback support in the
SimplifiedLowering. We use it to check the index bounds for keyed
property accesses.

Note to perf sheriffs: This will tank quite a few benchmarks, as the
operator makes some redundant branch elimination ineffective for
certain patterns of keyed accesses. This does require more serious
redundancy elimination, which we will do in a separate CL. So ignore
any regressions from this CL, we know there will be a few.

R=jarin@chromium.org
BUG=v8:4470,v8:5100
==========

to

==========
[turbofan] Introduce a dedicated CheckBounds operator.

This CheckBounds simplified operator is similar to the HBoundsCheck in
Crankshaft, and is hooked up to the new type feedback support in the
SimplifiedLowering. We use it to check the index bounds for keyed
property accesses.

Note to perf sheriffs: This will tank quite a few benchmarks, as the
operator makes some redundant branch elimination ineffective for
certain patterns of keyed accesses. This does require more serious
redundancy elimination, which we will do in a separate CL. So ignore
any regressions from this CL, we know there will be a few.

R=jarin@chromium.org
BUG=v8:4470,v8:5100

Committed: https://crrev.com/85e5567dae66a918500ae94c5568221137a0f5d4
Cr-Commit-Position: refs/heads/master@{#36947}
==========

[commit-bot: I haz the power, 2016-06-14 06:12:21]

Patchset 5 (id:??) landed as
https://crrev.com/85e5567dae66a918500ae94c5568221137a0f5d4
Cr-Commit-Position: refs/heads/master@{#36947}

[vogelheim, 2016-06-14 16:08:08]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2064163002/ by vogelheim@chromium.org.

The reason for reverting is: Speculative revert since V8 roll is blocked.

Buildbot:
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...

Example log:
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...


Failing assert:
#
# Fatal error in ../../v8/src/compiler/node.cc, line 63
# Node::New() Error: #202:DeoptimizeUnless[1] is nullptr
#


(I take it that's a rather generic assert in TF, hence the revert is somewhat
sepculative.).

[Benedikt Meurer, 2016-06-15 12:06:16]

Description was changed from

==========
[turbofan] Introduce a dedicated CheckBounds operator.

This CheckBounds simplified operator is similar to the HBoundsCheck in
Crankshaft, and is hooked up to the new type feedback support in the
SimplifiedLowering. We use it to check the index bounds for keyed
property accesses.

Note to perf sheriffs: This will tank quite a few benchmarks, as the
operator makes some redundant branch elimination ineffective for
certain patterns of keyed accesses. This does require more serious
redundancy elimination, which we will do in a separate CL. So ignore
any regressions from this CL, we know there will be a few.

R=jarin@chromium.org
BUG=v8:4470,v8:5100

Committed: https://crrev.com/85e5567dae66a918500ae94c5568221137a0f5d4
Cr-Commit-Position: refs/heads/master@{#36947}
==========

to

==========
[turbofan] Introduce a dedicated CheckBounds operator.

This CheckBounds simplified operator is similar to the HBoundsCheck in
Crankshaft, and is hooked up to the new type feedback support in the
SimplifiedLowering. We use it to check the index bounds for keyed
property accesses.

Note to perf sheriffs: This will tank quite a few benchmarks, as the
operator makes some redundant branch elimination ineffective for
certain patterns of keyed accesses. This does require more serious
redundancy elimination, which we will do in a separate CL. So ignore
any regressions from this CL, we know there will be a few.

R=jarin@chromium.org
BUG=v8:4470,v8:5100

Committed: https://crrev.com/85e5567dae66a918500ae94c5568221137a0f5d4
Cr-Commit-Position: refs/heads/master@{#36947}
==========

[Benedikt Meurer, 2016-06-15 12:18:23]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-06-15 12:18:24]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2035893004/#ps100001
(title: "REBASE")

[commit-bot: I haz the power, 2016-06-15 12:18:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-15 12:18:34]

This CL has an open dependency (Issue 2066223002 Patch 20001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[Benedikt Meurer, 2016-06-15 13:00:17]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-06-15 13:00:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2035893004/100001

[commit-bot: I haz the power, 2016-06-15 13:04:43]

Description was changed from

==========
[turbofan] Introduce a dedicated CheckBounds operator.

This CheckBounds simplified operator is similar to the HBoundsCheck in
Crankshaft, and is hooked up to the new type feedback support in the
SimplifiedLowering. We use it to check the index bounds for keyed
property accesses.

Note to perf sheriffs: This will tank quite a few benchmarks, as the
operator makes some redundant branch elimination ineffective for
certain patterns of keyed accesses. This does require more serious
redundancy elimination, which we will do in a separate CL. So ignore
any regressions from this CL, we know there will be a few.

R=jarin@chromium.org
BUG=v8:4470,v8:5100

Committed: https://crrev.com/85e5567dae66a918500ae94c5568221137a0f5d4
Cr-Commit-Position: refs/heads/master@{#36947}
==========

to

==========
[turbofan] Introduce a dedicated CheckBounds operator.

This CheckBounds simplified operator is similar to the HBoundsCheck in
Crankshaft, and is hooked up to the new type feedback support in the
SimplifiedLowering. We use it to check the index bounds for keyed
property accesses.

Note to perf sheriffs: This will tank quite a few benchmarks, as the
operator makes some redundant branch elimination ineffective for
certain patterns of keyed accesses. This does require more serious
redundancy elimination, which we will do in a separate CL. So ignore
any regressions from this CL, we know there will be a few.

R=jarin@chromium.org
BUG=v8:4470,v8:5100

Committed: https://crrev.com/85e5567dae66a918500ae94c5568221137a0f5d4
Cr-Commit-Position: refs/heads/master@{#36947}
==========

[commit-bot: I haz the power, 2016-06-15 13:04:45]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-06-15 13:07:30]

Description was changed from

==========
[turbofan] Introduce a dedicated CheckBounds operator.

This CheckBounds simplified operator is similar to the HBoundsCheck in
Crankshaft, and is hooked up to the new type feedback support in the
SimplifiedLowering. We use it to check the index bounds for keyed
property accesses.

Note to perf sheriffs: This will tank quite a few benchmarks, as the
operator makes some redundant branch elimination ineffective for
certain patterns of keyed accesses. This does require more serious
redundancy elimination, which we will do in a separate CL. So ignore
any regressions from this CL, we know there will be a few.

R=jarin@chromium.org
BUG=v8:4470,v8:5100

Committed: https://crrev.com/85e5567dae66a918500ae94c5568221137a0f5d4
Cr-Commit-Position: refs/heads/master@{#36947}
==========

to

==========
[turbofan] Introduce a dedicated CheckBounds operator.

This CheckBounds simplified operator is similar to the HBoundsCheck in
Crankshaft, and is hooked up to the new type feedback support in the
SimplifiedLowering. We use it to check the index bounds for keyed
property accesses.

Note to perf sheriffs: This will tank quite a few benchmarks, as the
operator makes some redundant branch elimination ineffective for
certain patterns of keyed accesses. This does require more serious
redundancy elimination, which we will do in a separate CL. So ignore
any regressions from this CL, we know there will be a few.

R=jarin@chromium.org
BUG=v8:4470,v8:5100

Committed: https://crrev.com/85e5567dae66a918500ae94c5568221137a0f5d4
Committed: https://crrev.com/2267ccb1bb173f563c08b7fb7e9cdf8c2bd5e332
Cr-Original-Commit-Position: refs/heads/master@{#36947}
Cr-Commit-Position: refs/heads/master@{#37003}
==========

[commit-bot: I haz the power, 2016-06-15 13:07:31]

Patchset 6 (id:??) landed as
https://crrev.com/2267ccb1bb173f563c08b7fb7e9cdf8c2bd5e332
Cr-Commit-Position: refs/heads/master@{#37003}