Issue 206403004: Change HarfBuzzShaper to use FloatBoxExtent for glyp bounds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 206403004: Change HarfBuzzShaper to use FloatBoxExtent for glyp bounds (Closed)

Created:
6 years, 9 months ago by eae

Modified:
6 years, 9 months ago

Reviewers:
dglazkov

CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Change HarfBuzzShaper to use FloatBoxExtent for glyp bounds Add new FloatBoxExtent class (to complement existing int and LayoutUnit versions) and update HarfBuzzShaper to use this class instead of four separate float values to represent the glyph bounding box. R=dglazkov@chromium.org BUG=354165 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169674

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -44 lines)			Patch
M	Source/platform/blink_platform.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/platform/fonts/harfbuzz/FontHarfBuzz.cpp	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/platform/fonts/harfbuzz/HarfBuzzShaper.h	View	3 chunks	+3 lines, -9 lines	0 comments	Download
M	Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp	View	2 chunks	+2 lines, -8 lines	0 comments	Download
A +	Source/platform/geometry/FloatBoxExtent.h	View	6 chunks	+39 lines, -23 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/206403004/1

6 years, 9 months ago (2014-03-20 18:11:18 UTC) #3

Message was sent while issue was closed.

Change committed as 169674

Expand Messages | Collapse Messages