Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2223)

Unified Diff: Source/platform/fonts/harfbuzz/HarfBuzzShaper.h

Issue 206403004: Change HarfBuzzShaper to use FloatBoxExtent for glyp bounds (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/fonts/harfbuzz/FontHarfBuzz.cpp ('k') | Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/fonts/harfbuzz/HarfBuzzShaper.h
diff --git a/Source/platform/fonts/harfbuzz/HarfBuzzShaper.h b/Source/platform/fonts/harfbuzz/HarfBuzzShaper.h
index 8145e9bce557ba0602620f6e7ed2d8e66ed040ac..9b2c60d4ef8c14cc979f60ea6ff6abd73e551462 100644
--- a/Source/platform/fonts/harfbuzz/HarfBuzzShaper.h
+++ b/Source/platform/fonts/harfbuzz/HarfBuzzShaper.h
@@ -33,6 +33,7 @@
#include "hb.h"
#include "platform/fonts/GlyphBuffer.h"
+#include "platform/geometry/FloatBoxExtent.h"
#include "platform/geometry/FloatPoint.h"
#include "platform/text/TextRun.h"
#include "wtf/HashSet.h"
@@ -60,11 +61,7 @@ public:
float totalWidth() { return m_totalWidth; }
int offsetForPosition(float targetX);
FloatRect selectionRect(const FloatPoint&, int height, int from, int to);
-
- float minGlyphBoundingBoxX() const { return m_minGlyphBoundingBoxX; }
- float maxGlyphBoundingBoxX() const { return m_maxGlyphBoundingBoxX; }
- float minGlyphBoundingBoxY() const { return m_minGlyphBoundingBoxY; }
- float maxGlyphBoundingBoxY() const { return m_maxGlyphBoundingBoxY; }
+ FloatBoxExtent glyphBoundingBox() const { return m_glyphBoundingBox; }
private:
class HarfBuzzRun {
@@ -163,10 +160,7 @@ private:
ForTextEmphasisOrNot m_forTextEmphasis;
float m_totalWidth;
- float m_minGlyphBoundingBoxX;
- float m_maxGlyphBoundingBoxX;
- float m_minGlyphBoundingBoxY;
- float m_maxGlyphBoundingBoxY;
+ FloatBoxExtent m_glyphBoundingBox;
friend struct CachedShapingResults;
};
« no previous file with comments | « Source/platform/fonts/harfbuzz/FontHarfBuzz.cpp ('k') | Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698