Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 206353003: Revert of Show IME when DPAD_CENTER is pressed (https://codereview.chromium.org/161933002/) (Closed)

Created:
6 years, 9 months ago by Primiano Tucci (use gerrit)
Modified:
6 years, 9 months ago
Reviewers:
benm (inactive)
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, aurimas (slooooooooow), hush (inactive), jdduke (slow), sgurun-gerrit only, bsears
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Show IME when DPAD_CENTER is pressed (https://codereview.chromium.org/161933002/) Reason for revert: Re-addressing this in crrev.com/206113005/ Original issue's description: > Show IME when DPAD_CENTER is pressed > > BUG=343311 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251447 TBR=jdduke@chromium.org,sgurun@chromium.org,aurimas@chromium.org,hush@chromium.org BUG=343311 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259936

Patch Set 1 #

Patch Set 2 : Keeping the setImeAdapterForTest method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -74 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 1 chunk +0 lines, -11 lines 0 comments Download
D content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreDpadTest.java View 1 chunk +0 lines, -63 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
benm (inactive)
lgtm
6 years, 9 months ago (2014-03-20 11:53:44 UTC) #1
Primiano Tucci (use gerrit)
The CQ bit was checked by primiano@chromium.org
6 years, 9 months ago (2014-03-27 17:08:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/206353003/20001
6 years, 9 months ago (2014-03-27 17:08:57 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 17:17:48 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 9 months ago (2014-03-27 17:17:48 UTC) #5
Primiano Tucci (use gerrit)
The CQ bit was checked by primiano@chromium.org
6 years, 9 months ago (2014-03-27 18:23:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/206353003/20001
6 years, 9 months ago (2014-03-27 18:24:30 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 18:26:42 UTC) #8
Message was sent while issue was closed.
Change committed as 259936

Powered by Google App Engine
This is Rietveld 408576698