Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 206353003: Revert of Show IME when DPAD_CENTER is pressed (https://codereview.chromium.org/161933002/) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Keeping the setImeAdapterForTest method Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreDpadTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
index 1e2073022916117bbd87a6891718301a741791f9..4d45d99895305f80e61e5aa6b068ff2f1df7f371 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
@@ -1689,17 +1689,6 @@ public class ContentViewCore
return mContainerViewInternals.super_dispatchKeyEvent(event);
}
- if (event.getKeyCode() == KeyEvent.KEYCODE_DPAD_CENTER) {
- showImeIfNeeded();
- // Event is not consumed here, because ImeAdapter might interpret
- // it as "Enter".
- // showImeIfNeeded respects the policy of
- // InputMethodService.onEvaluateInputViewShown. So IME will not be
- // shown if you have QWERTY physical keyboard attached.
- // Also, IME will not be shown if the focus is not on the input
- // field. See ImeAdapter.attachAndShowIfNeeded
- }
-
if (mImeAdapter.dispatchKeyEvent(event)) return true;
return mContainerViewInternals.super_dispatchKeyEvent(event);
« no previous file with comments | « no previous file | content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreDpadTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698