Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2063523002: aw: allow gl in HardwareRenderer constructor (Closed)

Created:
4 years, 6 months ago by boliu
Modified:
4 years, 6 months ago
Reviewers:
danakj
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aw: allow gl in HardwareRenderer constructor BUG=

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M android_webview/browser/render_thread_manager.cc View 1 chunk +7 lines, -4 lines 3 comments Download

Messages

Total messages: 5 (2 generated)
danakj
https://codereview.chromium.org/2063523002/diff/1/android_webview/browser/render_thread_manager.cc File android_webview/browser/render_thread_manager.cc (right): https://codereview.chromium.org/2063523002/diff/1/android_webview/browser/render_thread_manager.cc#newcode291 android_webview/browser/render_thread_manager.cc:291: hardware_renderer_->SetBackingFrameBufferObject( Do you mean for this to be above ...
4 years, 6 months ago (2016-06-10 23:13:10 UTC) #2
boliu
https://codereview.chromium.org/2063523002/diff/1/android_webview/browser/render_thread_manager.cc File android_webview/browser/render_thread_manager.cc (right): https://codereview.chromium.org/2063523002/diff/1/android_webview/browser/render_thread_manager.cc#newcode291 android_webview/browser/render_thread_manager.cc:291: hardware_renderer_->SetBackingFrameBufferObject( On 2016/06/10 23:13:10, danakj wrote: > Do you ...
4 years, 6 months ago (2016-06-10 23:15:01 UTC) #3
danakj
4 years, 6 months ago (2016-06-10 23:19:05 UTC) #4 
https://codereview.chromium.org/2063523002/diff/1/android_webview/browser/ren...
File android_webview/browser/render_thread_manager.cc (right):

https://codereview.chromium.org/2063523002/diff/1/android_webview/browser/ren...
android_webview/browser/render_thread_manager.cc:291:
hardware_renderer_->SetBackingFrameBufferObject(
On 2016/06/10 23:15:01, boliu wrote:
> On 2016/06/10 23:13:10, danakj wrote:
> > Do you mean for this to be above the creation of hardware_renderer_ now? It
> > won't be run the first time anymore.
> 
> I added it right below new HardwareRenderer too :)

Oh ok, I was thinking of just moving the ScopedAllowGL up above all of this, but
I can do it this way. Thanks. Patchset incoming.

Powered by Google App Engine
This is Rietveld 408576698