aw: allow gl in HardwareRenderer constructor

android_webview/browser/render_thread_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/browser/render_thread_manager.h"
 
 #include <utility>
 
 #include "android_webview/browser/child_frame.h"
 #include "android_webview/browser/compositor_frame_producer.h"
@@ skipping 269 matching lines @@
     }
   }
 
   ScopedAppGLStateRestore state_restore(
       draw_info->mode == AwDrawGLInfo::kModeDraw
           ? ScopedAppGLStateRestore::MODE_DRAW
           : ScopedAppGLStateRestore::MODE_RESOURCE_MANAGEMENT);
   // Set the correct FBO before kModeDraw. The GL commands run in kModeDraw
   // require a correctly bound FBO. The FBO remains until the next kModeDraw.
   // So kModeProcess between kModeDraws has correctly bound FBO, too.
-  if (draw_info->mode == AwDrawGLInfo::kModeDraw && !hardware_renderer_ &&
-      !IsInsideHardwareRelease() && HasFrameForHardwareRendererOnRT()) {
-    hardware_renderer_.reset(new HardwareRenderer(this));
-    hardware_renderer_->CommitFrame();
-  }
   if (hardware_renderer_) {
     hardware_renderer_->SetBackingFrameBufferObject(

[danakj, 2016/06/10 23:13:10]

Do you mean for this to be above the creation of hardware_renderer_ now? It
won't be run the first time anymore.

[boliu, 2016/06/10 23:15:01]

I added it right below new HardwareRenderer too :)

[danakj, 2016/06/10 23:19:05]

Oh ok, I was thinking of just moving the ScopedAllowGL up above all of this, but
I can do it this way. Thanks. Patchset incoming.

         state_restore.framebuffer_binding_ext());
   }
 
   ScopedAllowGL allow_gl;
+  if (draw_info->mode == AwDrawGLInfo::kModeDraw && !hardware_renderer_ &&
+      !IsInsideHardwareRelease() && HasFrameForHardwareRendererOnRT()) {
+    hardware_renderer_.reset(new HardwareRenderer(this));
+    hardware_renderer_->SetBackingFrameBufferObject(
+        state_restore.framebuffer_binding_ext());
+    hardware_renderer_->CommitFrame();
+  }
+
 
   if (draw_info->mode == AwDrawGLInfo::kModeProcessNoContext) {
     LOG(ERROR) << "Received unexpected kModeProcessNoContext";
   }
 
   if (IsInsideHardwareRelease()) {
     hardware_renderer_has_frame_ = false;
     hardware_renderer_.reset();
     // Flush the idle queue in tear down.
     DeferredGpuCommandService::GetInstance()->PerformAllIdleWork();
@@ skipping 82 matching lines @@
     : render_thread_manager_(render_thread_manager) {
   DCHECK(!render_thread_manager_->IsInsideHardwareRelease());
   render_thread_manager_->SetInsideHardwareRelease(true);
 }
 
 RenderThreadManager::InsideHardwareReleaseReset::~InsideHardwareReleaseReset() {
   render_thread_manager_->SetInsideHardwareRelease(false);
 }
 
 }  // namespace android_webview