Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2063503002: Make large test_support targets static libraries. (Closed)

Created:
4 years, 6 months ago by brettw
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke, dpranke
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make large test_support targets static libraries. On Windows this seems to make some tests link faster because the tests link to these larget targets but don't use most of them. The static library is much more efficient to link in this case since only the required compilation units are loaded. TBR=dpranke (split off of https://codereview.chromium.org/2043873004/ which already has review) BUG=617837 Committed: https://crrev.com/000e11f48c6a4b2540a4b9fcae87b839d1e64117 Cr-Commit-Position: refs/heads/master@{#399349}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M chrome/common/BUILD.gn View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M content/test/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
brettw
4 years, 6 months ago (2016-06-10 22:07:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063503002/1
4 years, 6 months ago (2016-06-10 22:09:01 UTC) #3
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-10 22:12:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-11 01:47:37 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-11 01:49:25 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/000e11f48c6a4b2540a4b9fcae87b839d1e64117
Cr-Commit-Position: refs/heads/master@{#399349}

Powered by Google App Engine
This is Rietveld 408576698