Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1151)

Unified Diff: content/test/BUILD.gn

Issue 2063503002: Make large test_support targets static libraries. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/BUILD.gn
diff --git a/content/test/BUILD.gn b/content/test/BUILD.gn
index c1d96d2131326872bcf4f138e19547ddbe561a55..c6f816bb1a2ed014e474ef70f8e43f58cd647f59 100644
--- a/content/test/BUILD.gn
+++ b/content/test/BUILD.gn
@@ -22,7 +22,10 @@ content_tests_gypi_values =
[ "../content_tests.gypi" ])
# GYP version //content/content_tests.gypi:test_support_content
-source_set("test_support") {
+#
+# Use a static library here because many test binaries depend on this but don't
+# require many files from it. This makes linking more efficient.
+static_library("test_support") {
testonly = true
# See comment at the top of //content/BUILD.gn for why this is disabled in
« no previous file with comments | « chrome/test/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698